Repository navigation
Process footgun fixes - #1090
Merged
Merged
Conversation
A misspelled or unregistered port name passed to input.get(), getData(), or getStream() crashed with TypeError: Cannot read properties of undefined (reading 'isAddressable') deep in the buffer machinery, while the has() family already threw a descriptive error. The read side now validates through the same gate, and both error paths name the component, the requested port, and the available ports — so the typo is diagnosable from the message alone.
Wrapping a component by name constructed it twice per invocation: once in AsPromise.prepareNetwork for port introspection, then again when the network loaded the same name through the loader — the first instance, with any constructor-acquired state, was discarded. Network.addNode now accepts pre-built component instances through the new instances network option (keyed by node id), and asPromise passes the introspected instance there. The component factory runs exactly once per wrapped call, pinned by a spec counting constructions.
forwardBrackets rules referencing ports the component does not have were silently deleted as dead config — a typo'd port name in the rule map disabled bracket forwarding with no signal. Rules the component declares itself (via options or by assignment before process()) now throw at construction naming the missing port. The built-in default rule keeps adapting silently to the ports the component actually has — components without out/error ports are correct usage, not a typo. The distinction is by identity: the default object is exempt until the component declares its own rule map. Verified against the migrated ecosystem: every declaring component in noflo-core constructs cleanly.
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.