8000 Document development setup by nirs · Pull Request #19 · nirs/minikube · GitHub
[go: up one dir, main page]

Skip to content

Document development setup - #19

Closed
nirs wants to merge 12 commits into
masterfrom
document-development-setup
Closed

nirs wants to merge 12 commits into
masterfrom
document-development-setup

Conversation

@nirs
@nirs nirs commented Nov 17, 2026
Copy link
Copy Markdown
Owner

No description provided.

dependabot Bot and others added 7 commits November 17, 2026 01:59
Bumps the golang-org group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [golang.org/x/crypto](https://github.com/golang/crypto) | `0.58.0` | `0.59.0` |
| [golang.org/x/mod](https://github.com/golang/mod) | `0.42.0` | `0.43.0` |
| [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.37.0` | `0.38.0` |
| [golang.org/x/sync](https://github.com/golang/sync) | `0.24.0` | `0.25.0` |
| [golang.org/x/sys](https://github.com/golang/sys) | `0.49.0` | `0.50.0` |
| [golang.org/x/term](https://github.com/golang/term) | `0.47.0` | `0.48.0` |
| [golang.org/x/text](https://github.com/golang/text) | `0.43.0` | `0.44.0` |


Updates `golang.org/x/crypto` from 0.58.0 to 0.59.0
- [Commits](golang/crypto@v0.58.0...v0.59.0)

Updates `golang.org/x/mod` from 0.42.0 to 0.43.0
- [Commits](golang/mod@v0.42.0...v0.43.0)

Updates `golang.org/x/oauth2` from 0.37.0 to 0.38.0
- [Commits](golang/oauth2@v0.37.0...v0.38.0)

Updates `golang.org/x/sync` from 0.24.0 to 0.25.0
- [Commits](golang/s
8000
ync@v0.24.0...v0.25.0)

Updates `golang.org/x/sys` from 0.49.0 to 0.50.0
- [Commits](golang/sys@v0.49.0...v0.50.0)

Updates `golang.org/x/term` from 0.47.0 to 0.48.0
- [Commits](golang/term@v0.47.0...v0.48.0)

Updates `golang.org/x/text` from 0.43.0 to 0.44.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.43.0...v0.44.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.59.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
- dependency-name: golang.org/x/mod
  dependency-version: 0.43.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
- dependency-name: golang.org/x/oauth2
  dependency-version: 0.38.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
- dependency-name: golang.org/x/sync
  dependency-version: 0.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
- dependency-name: golang.org/x/sys
  dependency-version: 0.50.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
- dependency-name: golang.org/x/term
  dependency-version: 0.48.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
- dependency-name: golang.org/x/text
  dependency-version: 0.44.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-org
...

Signed-off-by: dependabot[bot] <support@github.com>
…ules/golang-org-2ce7ba5544

chore(deps): bump the golang-org group with 7 updates
…version-d000e6b

Kicbase/ISO: Update runc from v1.5.2 to v1.5.3
@github-actions
Copy link
Copy Markdown

Hi @nirs, we have updated your PR with the reference to the newly built kicbase image quay.io/nirsof/kicbase:v0.0.51-1794953177-19 (sha256:a7ce7c5cbf3b9c2198119078317acf8a170dff1afdadfced782bdd3025fb95d7).
Pull the changes locally if you want to test with them or update your PR further.

Build logs: https://github.com/nirs/minikube/actions/runs/44186537219

nirs added 5 commits November 18, 2026 00:38
test.sh selects test packages with go list and runs go test without the
Makefile's libvirt_dlopen tag. On Linux/amd64 this compiles the libvirt
Go module in its default mode, which requires the libvirt development
headers and pkg-config files, breaking unit tests after those packages
were removed from CI.

Pass MINIKUBE_BUILD_TAGS from the Makefile test target and include it in
both go list and go test so unit tests use the same build configuration
as the minikube build.
golangci-lint and go vet do not use the Makefile build tags, so they
compile the libvirt Go module in its default mode, which requires the
libvirt development headers and pkg-config file. This mismatch is not
known to have caused lint or vet failures, but it leaves an unnecessary
build dependency.

Add libvirt_dlopen to the golangci-lint configurations and to the vet
target so these checks compile the same kvm driver configuration as the
build. With lint no longer requiring libvirt development packages, stop
installing libvirt-dev in the lint job.
Commit 7bc97d7 ("kvm: Convert to internal driver") made the kvm
driver an internal driver and started building minikube with the
libvirt_dlopen tag. In this mode the libvirt Go module does not include
the system libvirt headers or link against libvirt; it resolves the
libvirt symbols at runtime with dlopen.

The CI jobs still install libvirt-dev even though it is not needed for
building or unit tests. This also fails on systems where the package is
only available from an optional repository, such as CRB on Rocky Linux.

Remove the libvirt-dev installs from the build, unit test, translation,
and kicbase jobs, and remove the stale libvirt-dev requirement from the
testing guide.
The build pages require Go 1.22.0, but the bootstrap toolchain only needs
support for automatic toolchain downloads, which was added in Go 1.21.
The Makefile exports GOTOOLCHAIN from GO_VERSION, so an older Go
installation downloads and runs the pinned build toolchain.

Document Go 1.21.0 as the minimum and mention that the build downloads
the Go version specified by GO_VERSION automatically.
New contributors currently have to piece together the build dependencies
from the release build page, the testing page, CI workflows, and helper
scripts.

Add a setup section to the contributor guide covering Linux and macOS,
and point the binary build page directly to that section. The Linux
package lists do not include libvirt-devel because minikube builds with
the libvirt_dlopen tag and only needs the libvirt shared library at
runtime.

More work is needed to add the Windows section.

Refs: kubernetes#24058 (comment)
@nirs
nirs force-pushed the document-development-setup branch from 298c345 to eae3e48 Compare November 17, 2026 22:41
@nirs nirs closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0