8000 Test kicbase update pr by nirs · Pull Request #18 · nirs/minikube · GitHub
[go: up one dir, main page]

Skip to content

Test kicbase update pr - #18

Closed
nirs wants to merge 3 commits into
masterfrom
test-kicbase-update-pr
Closed

nirs wants to merge 3 commits into
masterfrom
test-kicbase-update-pr

Conversation

@nirs
@nirs nirs commented Nov 16, 2026
Copy link
Copy Markdown
Owner

No description provided.

nirs added 2 commits November 17, 2026 00:42
update-pr pushed with `MINIKUBE_BOT_PAT || GITHUB_TOKEN`, so a missing
bot PAT silently used the upstream GITHUB_TOKEN. That token has
contents: write on the base repository: pushing a fork head then failed
with 403, while a same-repository branch could be pushed as
github-actions[bot]. Either way the misconfiguration was invisible, and
the job held an upstream write capability the intended credential does
not need.

Choose the token by repository instead: kubernetes/minikube uses
MINIKUBE_BOT_PAT, a fork uses its own GITHUB_TOKEN for its own PR
branch. Keep the bot PAT non-empty with a descriptive fallback so gh
never treats GH_TOKEN as unset, and pass the fork token as
FORK_GITHUB_TOKEN so the default GITHUB_TOKEN name never enters the
environment and gh has nothing to fall back to.

contents: write stays on update-pr for the fork run; upstream does not
use it.
@github-actions
Copy link
Copy Markdown

Hi @nirs, we have updated your PR with the reference to the newly built kicbase image quay.io/nirsof/kicbase:v0.0.51-1794869497-18 (sha256:d1e7373848f7f05e9cb0d096604a3d8d33a7d3a7d286f3fe72fff5936fb2ce80).
Pull the changes locally if you want to test with them or update your PR further.

Build logs: https://github.com/nirs/minikube/actions/runs/43973926803

@nirs nirs closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0