Repository navigation
Conversation
update-pr pushed with `MINIKUBE_BOT_PAT || GITHUB_TOKEN`, so a missing bot PAT silently used the upstream GITHUB_TOKEN. That token has contents: write on the base repository: pushing a fork head then failed with 403, while a same-repository branch could be pushed as github-actions[bot]. Either way the misconfiguration was invisible, and the job held an upstream write capability the intended credential does not need. Choose the token by repository instead: kubernetes/minikube uses MINIKUBE_BOT_PAT, a fork uses its own GITHUB_TOKEN for its own PR branch. Keep the bot PAT non-empty with a descriptive fallback so gh never treats GH_TOKEN as unset, and pass the fork token as FORK_GITHUB_TOKEN so the default GITHUB_TOKEN name never enters the environment and gh has nothing to fall back to. contents: write stays on update-pr for the fork run; upstream does not use it.
|
Hi @nirs, we have updated your PR with the reference to the newly built kicbase image Build logs: https://github.com/nirs/minikube/actions/runs/43973926803 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.