Repository navigation
Conversation
Problem:
`KICBASE_REPO` is a complete image ref (`docker.io/kicbase/build`). It
duplicates `KICBASE_REGISTRY` and embeds the image name, so a fork has
to edit the registry inside the repo value and keep it in sync with the
login registry.
Solution:
Configure the image with three independent components:
`KICBASE_REGISTRY`, `KICBASE_REPO`, and `KICBASE_IMAGE`. The image ref
is `<registry>/<repo>/<image>:<kic_version>`.
Workflow structure:
- Prepare the image metadata once, then reference it in later steps.
- Keep image_ref (the untagged repository name) and kic_version (the
tag) as separate outputs. They match `gcrRepo/dockerhubRepo` and
`Version` in `pkg/drivers/kic/types.go`. Combine them as
`${image_ref}:${kic_version}` when needed.
workflow_dispatch:
- Add registry, repo, and image inputs. All are optional; blank values
fall back to `vars.KICBASE_*` and then to the static defaults.
- The repo input now means the org or username under the registry, not
a complete image ref.
Breaking changes:
The old combined `KICBASE_REPO` value is rejected in a new validate
input step. Repo settings using the previous value need to change.
For example, `quay.io/nirsof/minikube/kicbase` becomes:
KICBASE_REGISTRY=quay.io
KICBASE_REPO=nirsof/minikube
KICBASE_IMAGE=kicbase
Other changes:
- Add "Validate input" step validating input.* or vars.* early
- Log all step outputs for easier debugging
- Rename env names (PR_NUMBER) to match step outputs (pr_numebr)
|
Hi @nirs, we have updated your PR with the reference to the newly built kicbase image Build logs: https://github.com/nirs/minikube/actions/runs/43651702922 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.