8000 Testing kicbase config with issue_comment by nirs · Pull Request #15 · nirs/minikube · GitHub
[go: up one dir, main page]

Skip to content

Testing kicbase config with issue_comment - #15

Closed
nirs wants to merge 3 commits into
masterfrom
test-kicbase-config-comment
Closed

nirs wants to merge 3 commits into
masterfrom
test-kicbase-config-comment

Conversation

@nirs
@nirs nirs commented Nov 14, 2026
Copy link
Copy Markdown
Owner

No description provided.

nirs added 2 commits November 15, 2026 01:01
Problem:
`KICBASE_REPO` is a complete image ref (`docker.io/kicbase/build`). It
duplicates `KICBASE_REGISTRY` and embeds the image name, so a fork has
to edit the registry inside the repo value and keep it in sync with the
login registry.

Solution:
Configure the image with three independent components:
`KICBASE_REGISTRY`, `KICBASE_REPO`, and `KICBASE_IMAGE`. The image ref
is `<registry>/<repo>/<image>:<kic_version>`.

Workflow structure:
- Prepare the image metadata once, then reference it in later steps.
- Keep image_ref (the untagged repository name) and kic_version (the
  tag) as separate outputs. They match `gcrRepo/dockerhubRepo` and
  `Version` in `pkg/drivers/kic/types.go`. Combine them as
  `${image_ref}:${kic_version}` when needed.

workflow_dispatch:
- Add registry, repo, and image inputs. All are optional; blank values
  fall back to `vars.KICBASE_*` and then to the static defaults.
- The repo input now means the org or username under the registry, not
  a complete image ref.

Breaking changes:
The old combined `KICBASE_REPO` value is rejected in a new validate
input step. Repo settings using the previous value need to change.

For example, `quay.io/nirsof/minikube/kicbase` becomes:

    KICBASE_REGISTRY=quay.io
    KICBASE_REPO=nirsof/minikube
    KICBASE_IMAGE=kicbase

Other changes:
- Add "Validate input" step validating input.* or vars.* early
- Log all step outputs for easier debugging
- Rename env names (PR_NUMBER) to match step outputs (pr_numebr)
@nirs
nirs commented Nov 14, 2026
Copy link
Copy Markdown
Owner Author

ok-to-build-image

@nirs nirs changed the title Testing kicbase config with comment Testing kicbase config with issue_comment Nov 14, 2026
@github-actions
Copy link
Copy Markdown

Hi @nirs, we have updated your PR with the reference to the newly built kicbase image quay.io/nirsof/kicbase:v0.0.51-1794697404-15 (sha256:5fdaecda177a3bd9664d55bbd628d06d445046b6bd41f077eb1e8712a7c24394).
Pull the changes locally if you want to test with them or update your PR further.

Build logs: https://github.com/nirs/minikube/actions/runs/43651215866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0