8000 Testing kicbase update-pr by nirs · Pull Request #14 · nirs/minikube · GitHub
[go: up one dir, main page]

Skip to content

Testing kicbase update-pr - #14

Closed
nirs wants to merge 4 commits into
masterfrom
test-kicbase-update-pr
Closed

nirs wants to merge 4 commits into
masterfrom
test-kicbase-update-pr

Conversation

@nirs
@nirs nirs commented Nov 14, 2026
Copy link
Copy Markdown
Owner

No description provided.

nirs added 3 commits November 14, 2026 00:39
Problem:
KICBASE_REPO is a complete image ref (docker.io/kicbase/build). It duplicates
KICBASE_REGISTRY and embeds the image name, so a fork has to edit the registry
inside the repo value and keep it in sync with the login registry.

Solution:
Configure the image with three independent components:
KICBASE_REGISTRY, KICBASE_REPO, and KICBASE_IMAGE. The image ref is
<registry>/<repo>/<image>:<kic_version>.

Workflow structure:
- Prepare the image metadata once, then reference it in later steps.
- Keep image_ref (the untagged repository name) and kic_version (the tag) as
 separate outputs. They match gcrRepo/dockerhubRepo and Version in
 pkg/drivers/kic/types.go. Combine them as ${image_ref}:${kic_version}
 when needed.

workflow_dispatch:
- Add registry, repo, and image inputs. All are optional; blank values fall
 back to vars.KICBASE_* and then to the static defaults (docker.io, kicbase,
 build), which reproduce the existing docker.io/kicbase/build ref.
- The repo input now means the namespace/org path under the registry, not a
 complete image ref.

Breaking changes:
The old combined KICBASE_REPO value no longer works. Only the main minikube
repo and two developer forks use the old form, so no compatibility path is
needed; a stale combined value produces a malformed or non-existent target and
the push fails safely.

Update fork settings:
- KICBASE_REGISTRY: registry host (e.g. quay.io)
- KICBASE_REPO: namespace/org path (e.g. nirsof or nirsof/minikube)
- KICBASE_IMAGE: image name (e.g. kicbase)

For example, quay.io/nirsof/minikube/kicbase becomes:
 KICBASE_REGISTRY=quay.io
 KICBASE_REPO=nirsof/minikube
 KICBASE_IMAGE=kicbase

Docker Hub only supports namespace/image; registries such as Quay and GHCR
also allow nested paths.
update-pr pushed with `MINIKUBE_BOT_PAT || GITHUB_TOKEN`, so a missing
bot PAT silently used the upstream GITHUB_TOKEN. That token has
contents: write on the base repository: pushing a fork head then failed
with 403, while a same-repository branch could be pushed as
github-actions[bot]. Either way the misconfiguration was invisible, and
the job held an upstream write capability the intended credential does
not need.

Choose the token by repository instead: kubernetes/minikube uses
MINIKUBE_BOT_PAT, a fork uses its own GITHUB_TOKEN for its own PR
branch. Keep the bot PAT non-empty with a descriptive fallback so gh
never treats GH_TOKEN as unset, and pass the fork token as
FORK_GITHUB_TOKEN so the default GITHUB_TOKEN name never enters the
environment and gh has nothing to fall back to.

contents: write stays on update-pr for the fork run; upstream does not
use it.
@nirs
nirs commented Nov 14, 2026
Copy link
Copy Markdown
Owner Author

ok-to-build-image

@github-actions
Copy link
Copy Markdown

Hi @nirs, we have updated your PR with the reference to the newly built kicbase image quay.io/nirsof/kicbase:v0.0.51-1794629903-14 (sha256:3097c5573dd9a48a41eca665b1500fb39e77e52d32e248f25c554726a4124c7e).
Pull the changes locally if you want to test with them or update your PR further.

Build logs: https://github.com/nirs/minikube/actions/runs/43555915006

@nirs
nirs force-pushed the master branch 2 times, most recently from 02c5922 to 4bc5282 Compare November 14, 2026 23:01
@nirs nirs closed this Nov 14, 2026
@nirs
nirs deleted the test-kicbase-update-pr branch November 14, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0