8000 Testing kicbase build with issue_comment by nirs · Pull Request #13 · nirs/minikube · GitHub
[go: up one dir, main page]

Skip to content

Testing kicbase build with issue_comment - #13

Closed
nirs wants to merge 3 commits into
masterfrom
test-kicbase-config-comment
Closed

nirs wants to merge 3 commits into
masterfrom
test-kicbase-config-comment

Conversation

@nirs
@nirs nirs commented Nov 13, 2026
Copy link
Copy Markdown
Owner

No description provided.

nirs added 2 commits November 14, 2026 00:39
Problem:
KICBASE_REPO is a complete image ref (docker.io/kicbase/build). It duplicates
KICBASE_REGISTRY and embeds the image name, so a fork has to edit the registry
inside the repo value and keep it in sync with the login registry.

Solution:
Configure the image with three independent components:
KICBASE_REGISTRY, KICBASE_REPO, and KICBASE_IMAGE. The image ref is
<registry>/<repo>/<image>:<kic_version>.

Workflow structure:
- Prepare the image metadata once, then reference it in later steps.
- Keep image_ref (the untagged repository name) and kic_version (the tag) as
 separate outputs. They match gcrRepo/dockerhubRepo and Version in
 pkg/drivers/kic/types.go. Combine them as ${image_ref}:${kic_version}
 when needed.

workflow_dispatch:
- Add registry, repo, and image inputs. All are optional; blank values fall
 back to vars.KICBASE_* and then to the static defaults (docker.io, kicbase,
 build), which reproduce the existing docker.io/kicbase/build ref.
- The repo input now means the namespace/org path under the registry, not a
 complete image ref.

Breaking changes:
The old combined KICBASE_REPO value no longer works. Only the main minikube
repo and two developer forks use the old form, so no compatibility path is
needed; a stale combined value produces a malformed or non-existent target and
the push fails safely.

Update fork settings:
- KICBASE_REGISTRY: registry host (e.g. quay.io)
- KICBASE_REPO: namespace/org path (e.g. nirsof or nirsof/minikube)
- KICBASE_IMAGE: image name (e.g. kicbase)

For example, quay.io/nirsof/minikube/kicbase becomes:
 KICBASE_REGISTRY=quay.io
 KICBASE_REPO=nirsof/minikube
 KICBASE_IMAGE=kicbase

Docker Hub only supports namespace/image; registries such as Quay and GHCR
also allow nested paths.
@nirs
nirs commented Nov 13, 2026
Copy link
Copy Markdown
Owner Author

ok-to-build-image

@github-actions
Copy link
Copy Markdown

Hi @nirs, we have updated your PR with the reference to the newly built kicbase image quay.io/nirsof/kicbase:v0.0.51-1794611612-13 (sha256:a5734c9a9d893103a40c589bfd875745014a5c46c1dab7e1cdfbe67ee17e8c08).
Pull the changes locally if you want to test with them or update your PR further.

Build logs: https://github.com/nirs/minikube/actions/runs/43525376587

@nirs nirs closed this Nov 14, 2026
@nirs
nirs deleted the test-kicbase-config-comment branch November 14, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0