8000 kicbase: Pin Debian to the base image snapshot and clean up once by nirs · Pull Request #10 · nirs/minikube · GitHub
[go: up one dir, main page]

Skip to content

kicbase: Pin Debian to the base image snapshot and clean up once - #10

Closed
nirs wants to merge 2 commits into
masterfrom
pin-kicbase-snapshot
Closed

nirs wants to merge 2 commits into
masterfrom
pin-kicbase-snapshot

Conversation

@nirs
@nirs nirs commented Nov 7, 2026
Copy link
Copy Markdown
Owner

clean-install ran apt-get update against the rolling Debian mirror and then deleted the package index. A vim security upload published vim-common for every architecture before the matching s390x vim-tiny existed, so an unchanged trixie base failed to build.

Pin Debian apt to the snapshot URL recorded in the base image, so package versions stay fixed until that base tag changes. Fetch the Debian index once from that snapshot. Docker, cri-o, and NVIDIA are not in the snapshot: each adds its own repository and runs apt-get update before installing. clean-install only installs and leaves the index in place for the next install.

Remove the apt index, package caches, logs, docs, and man pages in a new runtime stage. The published image is copied from that stage, so deleting these files on every install only shrank intermediate build layers.

michaelasp and others added 2 commits November 5, 2026 15:01
clean-install ran apt-get update against the rolling Debian mirror and
then deleted the package index. A vim security upload published
vim-common for every architecture before the matching s390x vim-tiny
existed, so an unchanged trixie base failed to build.

Pin Debian apt to the snapshot URL recorded in the base image, so
package versions stay fixed until that base tag changes. Fetch the
Debian index once from that snapshot. Docker, cri-o, and NVIDIA are not
in the snapshot: each adds its own repository and runs apt-get update
before installing. clean-install only installs and leaves the index in
place for the next install.

Remove the apt index, package caches, logs, docs, and man pages in a new
runtime stage. The published image is copied from that stage, so
deleting these files on every install only shrank intermediate build
layers.
@nirs
nirs commented Nov 7, 2026
Copy link
Copy Markdown
Owner Author

ok-to-build-image

@github-actions
github-actions Bot commented Nov 7, 2026
Copy link
Copy Markdown

Hi @nirs, we built the kicbase image quay.io/nirsof/kicbase:v0.0.51-1794015661-10 (sha256:e79351d16fd3156f6a1e09e80ab06167fedc7f545017f1e0920e1036db26c531) but failed to update your PR.
Please run the following commands and push manually:

sed -i 's|Version = .*|Version = "v0.0.51-1794015661-10"|;s|baseImageSHA = .*|baseImageSHA = "e79351d16fd3156f6a1e09e80ab06167fedc7f545017f1e0920e1036db26c531"|;s|gcrRepo = .*|gcrRepo = "quay.io/nirsof/kicbase"|;s|dockerhubRepo = .*|dockerhubRepo = "quay.io/nirsof/kicbase"|' pkg/drivers/kic/types.go
make generate-docs

Build logs: https://github.com/nirs/minikube/actions/runs/42325298077

@nirs
nirs force-pushed the master branch 3 times, most recently from 4f36277 to b0ffb71 Compare November 10, 2026 21:07
@nirs nirs closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0