Repository navigation
Fix xgboost_lib-sys build on Rust 1.100 - #661
Merged
Merged
Conversation
Cargo 1.100 nests build script output one level deeper (build/<pkg>/<hash>/out instead of build/<pkg>-<hash>/out), so the hardcoded ../../../deps no longer exists. Find the profile directory as the parent of the ancestor named `build`, which works for both layouts. No functional changes to the crawler. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTbu4ortjqC5Z7Kw9377LE
On a clean build under Cargo 1.100 the profile's deps directory does not exist yet when the build script runs, so canonicalizing it failed with NotFound. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTbu4ortjqC5Z7Kw9377LE
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
mwmbl_rank/third_party/xgboost_lib-sys/build.rsnow finds the profile directory by walking up fromOUT_DIRto the first ancestor namedbuildand taking its parent, then uses<profile>/deps. Previously it used{OUT_DIR}/../../../deps.Why
Since Rust 1.100.0 (2026-11-09),
OUT_DIRistarget/release/build/xgboost_lib-sys/<hash>/out, one level deeper than the oldbuild/xgboost_lib-sys-<hash>/out.../../../depsno longer exists, sodunce::canonicalize(...).unwrap()panicked anduv sync(maturin build ofmwmbl_rank) failed in every workflow (CItest, Crawler smoke, Build and Push to GHCR). The new lookup is independent of layout depth, so it works on old and new toolchains. Nothing else inbuild.rsuses the layout, and.claude/hooks/session-start.shusesmwmbl_rank/target/<profile>/depsdirectly, so it needed no change.Verification
cargo +1.100.0 build --release -p xgboost_lib-sys: succeeds (reproduced the panic before the fix;libxgboost.sois intarget/release/deps).uv run maturin developunder the stable 1.97 toolchain (old layout): builds and installs.make check: passes.make test-file FILE="test/test_rank.py test/test_ranking_predictor.py": 21 passed.Only the build script changes, so the crawler is unaffected (
No functional changes to the crawler.is in the commit message).This unblocks the widget PRs #653-#658.
Generated by Claude Code