8000 Fix xgboost_lib-sys build on Rust 1.100 by daoudclarke · Pull Request #661 · mwmbl/mwmbl · GitHub
[go: up one dir, main page]

Skip to content

Fix xgboost_lib-sys build on Rust 1.100 - #661

Merged
daoudclarke merged 2 commits into
mainfrom
claude/fix-rust-1100-build
Nov 13, 2026
Merged

daoudclarke merged 2 commits into
mainfrom
claude/fix-rust-1100-build

Conversation

@daoudclarke
Copy link
Copy Markdown
Contributor

What changed

mwmbl_rank/third_party/xgboost_lib-sys/build.rs now finds the profile directory by walking up from OUT_DIR to the first ancestor named build and taking its parent, then uses <profile>/deps. Previously it used {OUT_DIR}/../../../deps.

Why

Since Rust 1.100.0 (2026-11-09), OUT_DIR is target/release/build/xgboost_lib-sys/<hash>/out, one level deeper than the old build/xgboost_lib-sys-<hash>/out. ../../../deps no longer exists, so dunce::canonicalize(...).unwrap() panicked and uv sync (maturin build of mwmbl_rank) failed in every workflow (CI test, Crawler smoke, Build and Push to GHCR). The new lookup is independent of layout depth, so it works on old and new toolchains. Nothing else in build.rs uses the layout, and .claude/hooks/session-start.sh uses mwmbl_rank/target/<profile>/deps directly, so it needed no change.

Verification

  • cargo +1.100.0 build --release -p xgboost_lib-sys: succeeds (reproduced the panic before the fix; libxgboost.so is in target/release/deps).
  • uv run maturin develop under the stable 1.97 toolchain (old layout): builds and installs.
  • make check: passes.
  • make test-file FILE="test/test_rank.py test/test_ranking_predictor.py": 21 passed.

Only the build script changes, so the crawler is unaffected (No functional changes to the crawler. is in the commit message).

This unblocks the widget PRs #653-#658.


Generated by Claude Code

Cargo 1.100 nests build script output one level deeper
(build/<pkg>/<hash>/out instead of build/<pkg>-<hash>/out), so the
hardcoded ../../../deps no longer exists. Find the profile directory as
the parent of the ancestor named `build`, which works for both layouts.

No functional changes to the crawler.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DTbu4ortjqC5Z7Kw9377LE
On a clean build under Cargo 1.100 the profile's deps directory does not exist
yet when the build script runs, so canonicalizing it failed with NotFound.

No functional changes to the crawler.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DTbu4ortjqC5Z7Kw9377LE
@codecov
codecov Bot commented Nov 13, 2026
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@daoudclarke
daoudclarke merged commit cce49fa into main Nov 13, 2026
7 checks passed
@daoudclarke
daoudclarke deleted the claude/fix-rust-1100-build branch November 13, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0