Repository navigation
Split weekly registrations into verified and unverified - #667
Merged
Merged
Conversation
The registration spikes on the stats page (Jan, Feb, Mar and late Apr 2026) were bot sign-ups: 1-3% of them ever verified their email, against 57% in a normal week, with random-string usernames. Returning the two counts separately lets the front-end show them as a stacked chart, so the real acquisition curve is visible under the bot noise. users_registered_weekly stays as the total for front-ends that predate the split. The cache keys are versioned because a payload cached by the previous release lacks the new fields and would fail validation. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on lags Addresses review of #667. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Claude:
What
/api/v1/crawler/statsnow returns two new series next tousers_registered_weekly:users_verified_weekly: users registered that week who have a verified email addressusers_unverified_weekly: everyone else registered that weekusers_registered_weeklystays as the total (verified + unverified), so existing front-ends keep working. The front-end can draw the two new series as a stacked chart.Why
The registration graph has large spikes in the weeks of 12 Jan, 16 Feb, 9–23 Mar and 27 Apr–4 May 2026. None of them line up with HN or blog coverage. Checking prod showed they are bot sign-ups:
The spike usernames are random strings (
IiFzMtomUfSgjeQuAo,qldunshvfn, …). Splitting by verification shows the real acquisition curve under the bot noise.Notes
EmailAddress, checked with anExistssubquery, so one query still covers the whole year.users-registered-weekly-v2-…,stats-payload-v2-…). A payload cached by the previous release lacks the new fields, and it would fail validation for up to an hour after the deploy.Verification
make checkpasses, andmake testpasses: 2194 passed, 10 skipped.🤖 Generated with Claude Code