8000 [pull] master from tdewolff:master by pull[bot] · Pull Request #209 · RepoBackup/minify · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions minify.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ var cmdArgExtension = regexp.MustCompile(`^\.[0-9a-zA-Z]+`)
func (c *cmdMinifier) Minify(_ *M, w io.Writer, r io.Reader, _ map[string]string) error {
cmd := &exec.Cmd{}
*cmd = *c.cmd // concurrency safety
cmd.Args = slices.Clone(c.cmd.Args)

var in, out *os.File
for i, arg := range cmd.Args {
Expand Down Expand Up @@ -100,8 +101,6 @@ func (c *cmdMinifier) Minify(_ *M, w io.Writer, r io.Reader, _ map[string]string
}
if out == nil {
cmd.Stdout = w
} else {
defer io.Copy(w, out)
}
stderr := &bytes.Buffer{}
cmd.Stderr = stderr
Expand All @@ -113,6 +112,12 @@ func (c *cmdMinifier) Minify(_ *M, w io.Writer, r io.Reader, _ map[string]string
}
err = fmt.Errorf("command %s failed: %w", cmd.Path, err)
}
if out != nil {
_, copyErr := io.Copy(w, out)
if err == nil {
return copyErr
}
}
return err
}

Expand Down
47 changes: 47 additions & 0 deletions minify_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"os"
"os/exec"
"regexp"
"slices"
"strings"
"testing"

Expand Down Expand Up @@ -136,6 +137,52 @@ func TestAdd(t *testing.T) {
test.String(t, s[len(s)-13:], "exit status 2")
}

type commandOutputWriter struct {
err error
}

func (w commandOutputWriter) Write([]byte) (int, error) {
return 0, w.err
}

func TestCommandOutputWriteError(t *testing.T) {
for _, tc := range []struct {
name string
writeErr, want error
}{
{"error", errDummy, errDummy},
{"short-write", nil, io.ErrShortWrite},
} {
t.Run(tc.name, func(t *testing.T) {
m := New()
m.AddCmd("dummy/file", helperCommand(t, "dummy/file", "-in=[$in.ext]", "-out=$out.ext"))
err := m.Minify("dummy/file", commandOutputWriter{tc.writeErr}, strings.NewReader("test"))
if !errors.Is(err, tc.want) {
t.Fatalf("got %v, want %v", err, tc.want)
}
})
}
}

func TestCommandArgumentsReusable(t *testing.T) {
cmd := helperCommand(t, "dummy/file", "-in=[$in.ext]", "-out=$out.ext")
args := slices.Clone(cmd.Args)
m := New()
m.AddCmd("dummy/file", cmd)
for _, input := range []string{"first", "second"} {
var out bytes.Buffer
if err := m.Minify("dummy/file", &out, strings.NewReader(input)); err != nil {
t.Fatal(err)
}
if out.String() != input {
t.Fatalf("got %q, want %q", out.String(), input)
}
if !slices.Equal(cmd.Args, args) {
t.Fatalf("command arguments changed: got %q, want %q", cmd.Args, args)
}
}
}

func TestMatch(t *testing.T) {
pattern, params, _ := m.Match("dummy/copy; a=b")
test.String(t, pattern, "dummy/copy")
Expand Down
Loading
0