Repository navigation
CI: use Python 3.12 and stop installing jsondiff - #570
Merged
Merged
Conversation
ubuntu-latest now resolves to Ubuntu 26.04, for which actions/setup-python has no Python 3.10.11 build, so the x64 Linux job fails in its setup step. That job never used the host interpreter: dcmqi is configured, built and tested inside the dockcross container, which has its own Pythons. The only host use was `pip install jsondiff`, and jsondiff is not imported anywhere -- util/comparejson.py uses the vendored util/jsoncompare.py. Drop setup-python from that job and jsondiff from every job, including the arm64 container. On macOS and Windows the setup-python interpreter is still needed, for the install-dicom3tools action (wheels require Python >= 3.10) and for the comparejson.py tests. Move it from 3.10.11 to 3.12; Python 3.10 reached end of life in October 2026. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
SonarCloud (githubactions:S7689) flags the backtick command substitution in the docker publish step. Use $() instead, and quote the image name so the tag cannot be word-split. The resulting tag is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ubuntu-latestnow resolves to Ubuntu 26.04, whereactions/setup-pythonhas no Python 3.10.11 build, so the x64 Linux job fails at setup:This keeps that job on
ubuntu-latestand removes the reason it broke.Changes
setup-pythonandpip install jsondiff. The build and tests run inside the dockcross container (docker/Makefile), which has its own interpreters, so the host Python was unused.jsondiffinto the manylinux container.setup-pythonfrom 3.10.11 to 3.12 and dropjsondiff. Python 3.10 reached end of life in October 2026.Why this is safe
jsondiffis not used anywhere.util/comparejson.pyimports the vendoredutil/jsoncompare.py, plusjsonandast. The Linux x64 tests already run it under the container's Python 3.8.install-dicom3toolsaction (the wheels require Python >= 3.10) and thecomparejson.pytests, and 3.12 meets both.#569 pins the x64 Linux job to
ubuntu-24.04as a stopgap for the same failure. That pin can be dropped once this is merged.🤖 Generated with Claude Code