8000 CI: use Python 3.12 and stop installing jsondiff by fedorov · Pull Request #570 · QIICR/dcmqi · GitHub
[go: up one dir, main page]

Skip to content

CI: use Python 3.12 and stop installing jsondiff - #570

Merged
fedorov merged 2 commits into
masterfrom
ci/python-3.12-ubuntu-latest
Nov 16, 2026
Merged

fedorov merged 2 commits into
masterfrom
ci/python-3.12-ubuntu-latest

Conversation

@fedorov
@fedorov fedorov commented Nov 16, 2026
Copy link
Copy Markdown
Member

ubuntu-latest now resolves to Ubuntu 26.04, where actions/setup-python has no Python 3.10.11 build, so the x64 Linux job fails at setup:

##[error]The version '3.10.11' with architecture 'x64' was not found for Ubuntu 26.04.

This keeps that job on ubuntu-latest and removes the reason it broke.

Changes

  • Linux x64: drop setup-python and pip install jsondiff. The build and tests run inside the dockcross container (docker/Makefile), which has its own interpreters, so the host Python was unused.
  • Linux arm64: stop installing jsondiff into the manylinux container.
  • macOS and Windows: move setup-python from 3.10.11 to 3.12 and drop jsondiff. Python 3.10 reached end of life in October 2026.

Why this is safe

  • jsondiff is not used anywhere. util/comparejson.py imports the vendored util/jsoncompare.py, plus json and ast. The Linux x64 tests already run it under the container's Python 3.8.
  • macOS and Windows still need a host Python. It runs the install-dicom3tools action (the wheels require Python >= 3.10) and the comparejson.py tests, and 3.12 meets both.
  • The cached dependencies are unaffected. The macOS and Windows caches hold only the DCMTK, ITK and zlib trees. dcmqi's own CMake cache, which records the interpreter path, is not cached.

#569 pins the x64 Linux job to ubuntu-24.04 as a stopgap for the same failure. That pin can be dropped once this is merged.

🤖 Generated with Claude Code

ubuntu-latest now resolves to Ubuntu 26.04, for which actions/setup-python
has no Python 3.10.11 build, so the x64 Linux job fails in its setup step.

That job never used the host interpreter: dcmqi is configured, built and
tested inside the dockcross container, which has its own Pythons. The only
host use was `pip install jsondiff`, and jsondiff is not imported anywhere --
util/comparejson.py uses the vendored util/jsoncompare.py. Drop setup-python
from that job and jsondiff from every job, including the arm64 container.

On macOS and Windows the setup-python interpreter is still needed, for the
install-dicom3tools action (wheels require Python >= 3.10) and for the
comparejson.py tests. Move it from 3.10.11 to 3.12; Python 3.10 reached end
of life in October 2026.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude claude Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

SonarCloud (githubactions:S7689) flags the backtick command substitution
in the docker publish step. Use $() instead, and quote the image name so
the tag cannot be word-split. The resulting tag is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

@fedorov
fedorov merged commit 3a4bd3e into master Nov 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0