Repository navigation
Accept SDK names in CMAKE_OSX_SYSROOT - #566
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change implements the intended behavior while preserving absolute-path validation, with no identified blocking issues.
0 open findings
What changed in this PR
Allows CMake to resolve SDK names in CMAKE_OSX_SYSROOT without rejecting them as missing files.
Changes:
- Limits the existence check to absolute paths.
- Preserves the error for missing absolute SDK paths.
| File | Description |
|---|---|
| CMake/dcmqiBlockSetCMakeOSXVariables.cmake | Adds an absolute-path condition to SDK path validation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CMAKE_OSX_SYSROOT accepts SDK names such as macosx as well as filesystem paths. The existing existence check rejects SDK names as missing files. Limit this guard to absolute paths, preserving the error for a missing absolute SDK path while allowing CMake to resolve SDK names.
Validation: retained focused synthetic CMake script evidence fails on macosx before the change and passes afterward; the same check also confirms that a missing absolute SDK path still fails. No unchanged checks were rerun for publication.
This verifies the configuration guard only. Native compilation and Apple Silicon hardware behavior were not tested; the change is not ARM64-specific.