8000 Accept SDK names in CMAKE_OSX_SYSROOT by jdotc1 · Pull Request #566 · QIICR/dcmqi · GitHub
[go: up one dir, main page]

Skip to content

Accept SDK names in CMAKE_OSX_SYSROOT - #566

Merged
fedorov merged 1 commit into
QIICR:masterfrom
jdotc1:fix/accept-macos-sdk-sysroot-names
Oct 14, 2026
Merged

fedorov merged 1 commit into
QIICR:masterfrom
jdotc1:fix/accept-macos-sdk-sysroot-names

Conversation

@jdotc1
@jdotc1 jdotc1 commented Oct 14, 2026
Copy link
Copy Markdown
Contributor

CMAKE_OSX_SYSROOT accepts SDK names such as macosx as well as filesystem paths. The existing existence check rejects SDK names as missing files. Limit this guard to absolute paths, preserving the error for a missing absolute SDK path while allowing CMake to resolve SDK names.

Validation: retained focused synthetic CMake script evidence fails on macosx before the change and passes afterward; the same check also confirms that a missing absolute SDK path still fails. No unchanged checks were rerun for publication.

This verifies the configuration guard only. Native compilation and Apple Silicon hardware behavior were not tested; the change is not ARM64-specific.

@sonarqubecloud
Copy link
Copy Markdown

Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow change implements the intended behavior while preserving absolute-path validation, with no identified blocking issues.

0 open findings

What changed in this PR

Allows CMake to resolve SDK names in CMAKE_OSX_SYSROOT without rejecting them as missing files.

Changes:

  • Limits the existence check to absolute paths.
  • Preserves the error for missing absolute SDK paths.
File Description
CMake/​dcmqiBlockSetCMakeOSXVariables.cmake Adds an absolute-path condition to SDK path validation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@fedorov
fedorov merged commit 73a0a17 into QIICR:master Oct 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0