Repository navigation
Preserve model objects when renamed keys overlap existing names - #372
Open
Tonylo-lab wants to merge 1 commit into
Open
Tonylo-lab wants to merge 1 commit into
Tonylo-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEModel3D.rename()can overwrite an object whose old name matches another object's new name. Creating N2 before N1 and callingrename()leaves only one node; elements still reference the missing node, and a two-node spring model subsequently raisesTypeErrorduring analysis. The same collision affects springs, members, plates and quads.Clear each dictionary after taking its existing snapshot, then populate the numbered keys from that snapshot. This preserves the objects, dictionary identity and insertion order. Apply the same two-line change in all five existing rename loops and add one explanatory comment. Add six focused cases in
Testing/test_rename.py(the five object dictionaries, with a repeated-rename control, plus an actual spring analysis) and one short changelog entry.The spring check uses F=10 and k=100: after renaming, displacement is F/k=0.1 and the fixed reaction is -10.
Validation on Windows / Python 3.12.15, based on
fdf3e12b:pytest Testing/test_rename.py Testing/test_node_spring_coverage.py Testing/test_node_merge.py Testing/test_springs.py Testing/test_reactions.py Testing/test_2D_frames.py -q: 38 passed, 8 subtests passed.git diff --check: passed.Not run: the full test suite, graphical visualization validation, or other platforms/Python versions.
AI assistance: OpenAI Codex assisted with investigation, the patch and regression tests. The concrete diff and validation results were presented for approval before submission.