8000 Avoid shared default factors between load combinations by Tonylo-lab · Pull Request #370 · JWock82/Pynite · GitHub
[go: up one dir, main page]

Skip to content

Avoid shared default factors between load combinations - #370

Open
Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/loadcombo-default-factors
Open

Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/loadcombo-default-factors

Conversation

@Tonylo-lab
Copy link
Copy Markdown

Directly constructing two LoadCombo objects without factors shares the default dictionary. Adding a case through AddLoadCase() therefore changes both combinations. In a one-unit cantilever with D=-10 and L=-5, separate 1.2D and 1.6L combinations both produce a reaction of 20 instead of 12 and 8.

Use a None default and create an empty factor dictionary per combination. Keep explicitly supplied dictionaries as before and clarify the parameter description. Add two tests to the existing TestLoadCombo class: factor isolation (including a later instance and deletion) and actual cantilever analysis. Add one short changelog entry.

Scope: this affects directly constructed LoadCombo objects with omitted factors. The existing tests exercise this construction, and the maintainer permits directly creating and registering model objects: #328 (comment)

Validation on Windows / Python 3.12.15:

  • New tests on unmodified production code: 2 failed.
  • pytest Testing/test_material_section_coverage.py Testing/test_loads.py Testing/test_reactions.py Testing/test_reanalysis.py Testing/test_continuous_beam.py Testing/test_2D_frames.py -q: 36 passed, 10 subtests passed.
  • Ruff 0.14.9 on the changed Python files and git diff --check: passed.

Not run: the full test suite, graphical visualization validation, or other platforms/Python versions.

AI assistance: OpenAI Codex assisted with investigation, the patch and regression tests. The concrete diff and validation results were presented for approval before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0