Repository navigation
Avoid shared default factors between load combinations - #370
Open
Tonylo-lab wants to merge 1 commit into
Open
Tonylo-lab wants to merge 1 commit into
Tonylo-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly constructing two
LoadComboobjects withoutfactorsshares the default dictionary. Adding a case throughAddLoadCase()therefore changes both combinations. In a one-unit cantilever with D=-10 and L=-5, separate 1.2D and 1.6L combinations both produce a reaction of 20 instead of 12 and 8.Use a
Nonedefault and create an empty factor dictionary per combination. Keep explicitly supplied dictionaries as before and clarify the parameter description. Add two tests to the existingTestLoadComboclass: factor isolation (including a later instance and deletion) and actual cantilever analysis. Add one short changelog entry.Scope: this affects directly constructed
LoadComboobjects with omitted factors. The existing tests exercise this construction, and the maintainer permits directly creating and registering model objects: #328 (comment)Validation on Windows / Python 3.12.15:
pytest Testing/test_material_section_coverage.py Testing/test_loads.py Testing/test_reactions.py Testing/test_reanalysis.py Testing/test_continuous_beam.py Testing/test_2D_frames.py -q: 36 passed, 10 subtests passed.git diff --check: passed.Not run: the full test suite, graphical visualization validation, or other platforms/Python versions.
AI assistance: OpenAI Codex assisted with investigation, the patch and regression tests. The concrete diff and validation results were presented for approval before submission.