8000 Clear stored helper loads in delete_loads() by Tonylo-lab · Pull Request #369 · JWock82/Pynite · GitHub
[go: up one dir, main page]

Skip to content

Clear stored helper loads in delete_loads() - #369

Open
Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/delete-loads-helper-records
Open

Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/delete-loads-helper-records

Conversation

@Tonylo-lab
Copy link
Copy Markdown

delete_loads() clears loads already applied to elements and nodes, but leaves loads stored by shear-wall and mat-foundation helpers. A later generate() (including automatic generation during analysis) restores those deleted loads.

Clear the helpers' shear, axial and point-load lists alongside the existing cleanup. This follows the documented "all loads" behavior, including story stiffness test loads; geometry, stories and load-combination definitions are retained. Add four focused cases to the existing load tests (wall/mat, before/after generation), including adding fresh loads after deletion, plus one short changelog entry.

Validation on Windows / Python 3.12.15:

  • New tests against unmodified production code: 4 failed.
  • pytest Testing/test_loads.py Testing/test_analysis_regeneration.py Testing/test_needs_update_flag.py Testing/test_reanalysis.py Testing/test_reactions.py -q: 26 passed, 2 subtests passed.
  • Ruff 0.14.9 on the changed Python files and git diff --check: passed.

Testing/test_shear_wall.py could not be collected because the local environment lacks the optional PyVista dependency. The full test suite, graphical visualization validation, and other platforms/Python versions were not run.

AI assistance: OpenAI Codex assisted with investigation, the patch and regression tests. The concrete diff and validation results were presented for approval before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0