Repository navigation
Clear stored helper loads in delete_loads() - #369
Open
Tonylo-lab wants to merge 1 commit into
Open
Tonylo-lab wants to merge 1 commit into
Tonylo-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_loads()clears loads already applied to elements and nodes, but leaves loads stored by shear-wall and mat-foundation helpers. A latergenerate()(including automatic generation during analysis) restores those deleted loads.Clear the helpers' shear, axial and point-load lists alongside the existing cleanup. This follows the documented "all loads" behavior, including story stiffness test loads; geometry, stories and load-combination definitions are retained. Add four focused cases to the existing load tests (wall/mat, before/after generation), including adding fresh loads after deletion, plus one short changelog entry.
Validation on Windows / Python 3.12.15:
pytest Testing/test_loads.py Testing/test_analysis_regeneration.py Testing/test_needs_update_flag.py Testing/test_reanalysis.py Testing/test_reactions.py -q: 26 passed, 2 subtests passed.git diff --check: passed.Testing/test_shear_wall.pycould not be collected because the local environment lacks the optional PyVista dependency. The full test suite, graphical visualization validation, and other platforms/Python versions were not run.AI assistance: OpenAI Codex assisted with investigation, the patch and regression tests. The concrete diff and validation results were presented for approval before submission.