8000 Fix mesh result filtering by load combination tags by Tonylo-lab · Pull Request #367 · JWock82/Pynite · GitHub
[go: up one dir, main page]

Skip to content

Fix mesh result filtering by load combination tags - #367

Open
Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/mesh-result-combo-tags
Open

Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/mesh-result-combo-tags

Conversation

@Tonylo-lab
Copy link
Copy Markdown

The six mesh result-envelope helpers read LoadCombo.tags, but load combinations store their tags in combo_tags. Consequently, the documented tag-list query, such as mesh.max_moment('My', combo_tags=['ULS']), raises AttributeError.

Use the correct attribute in all six helpers and treat unset tags as empty. Add 12 parameterized regression/control cases to the existing mesh tests (six helpers across Quad and Rect elements), plus one short changelog entry. The tests solve real meshes and compare tag-selected envelopes with named-combination results; they also cover unrelated/untagged combinations, any matching tag, and empty/unmatched selections.

Validation on Windows (Python 3.12.15, NumPy 2.5.5, SciPy 1.18.1):

  • New tests against unmodified production code: all 12 fail with the same AttributeError.
  • pytest Testing/test_meshes.py Testing/test_node_merge.py -q: 20 passed.
  • Ruff 0.14.9 on both changed Python files and git diff --check: passed.

Not run: the full test suite, graphical visualization validation, or tests on other platforms/Python versions.

AI assistance: OpenAI Codex assisted with investigation, the patch, and the regression tests. The concrete diff was presented for approval before submission, and the targeted checks above were run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0