8000 Remove connected springs when deleting a node by Tonylo-lab · Pull Request #366 · JWock82/Pynite · GitHub
[go: up one dir, main page]

Skip to content

Remove connected springs when deleting a node - #366

Open
Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/delete-node-connected-springs
Open

Tonylo-lab wants to merge 1 commit into
JWock82:mainfrom
Tonylo-lab:fix/delete-node-connected-springs

Conversation

@Tonylo-lab
Copy link
Copy Markdown

delete_node() documents that connected elements are removed, but currently leaves spring elements referencing the deleted node. Subsequent analysis can raise a TypeError before the first solve or an out-of-bounds ValueError during reanalysis.

Filter connected springs alongside the existing member/plate/quad cleanup, preserving unrelated springs. Add two parameterized regression cases to Testing/test_springs.py (deletion before the initial analysis and after an analysis) and one short changelog entry. The minimal three-node spring model exercises both i/j endpoints and checks the surviving spring's displacement against F/k and its support reaction.

Validation on Windows (Python 3.12.15, NumPy 2.5.5, SciPy 1.18.1):

  • New tests against unmodified production code: both cases fail.
  • pytest Testing/test_springs.py Testing/test_node_spring_coverage.py Testing/test_spring_support.py Testing/test_reanalysis.py Testing/test_node_merge.py -q: 30 passed.
  • Ruff 0.14.9 on both changed Python files and git diff --check: passed.

Not run: the full test suite, graphical visualization validation, or tests on other platforms/Python versions.

AI assistance: OpenAI Codex assisted with investigation, the patch, and the regression tests. The concrete diff was presented for approval before submission, and the targeted checks above were run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0