Repository navigation
Remove connected springs when deleting a node - #366
Open
Tonylo-lab wants to merge 1 commit into
Open
Tonylo-lab wants to merge 1 commit into
Tonylo-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_node()documents that connected elements are removed, but currently leaves spring elements referencing the deleted node. Subsequent analysis can raise aTypeErrorbefore the first solve or an out-of-boundsValueErrorduring reanalysis.Filter connected springs alongside the existing member/plate/quad cleanup, preserving unrelated springs. Add two parameterized regression cases to
Testing/test_springs.py(deletion before the initial analysis and after an analysis) and one short changelog entry. The minimal three-node spring model exercises both i/j endpoints and checks the surviving spring's displacement against F/k and its support reaction.Validation on Windows (Python 3.12.15, NumPy 2.5.5, SciPy 1.18.1):
pytest Testing/test_springs.py Testing/test_node_spring_coverage.py Testing/test_spring_support.py Testing/test_reanalysis.py Testing/test_node_merge.py -q: 30 passed.git diff --check: passed.Not run: the full test suite, graphical visualization validation, or tests on other platforms/Python versions.
AI assistance: OpenAI Codex assisted with investigation, the patch, and the regression tests. The concrete diff was presented for approval before submission, and the targeted checks above were run locally.