8000 Ruff unused variables by ulgens · Pull Request #338 · JWock82/Pynite · GitHub
[go: up one dir, main page]

Skip to content

Ruff unused variables - #338

Merged
JWock82 merged 4 commits into
JWock82:mainfrom
ulgens:ruff-unused-variables
Oct 20, 2026
Merged

JWock82 merged 4 commits into
JWock82:mainfrom
ulgens:ruff-unused-variables

Conversation

@ulgens
@ulgens ulgens commented Sep 14, 2026
Copy link
Copy Markdown
Contributor

Another incremental improvement with lint setup. Enables F841: https://docs.astral.sh/ruff/rules/unused-variable/

Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Enables Ruff’s F841 unused-variable check and removes unused assignments across tests, visualization, rendering, and analysis code.

Changes:

  • Enables Ruff rule F841.
  • Removes unused test variables and calculations.
  • Cleans unused rendering and analysis locals.
File summaries
File Description
Testing/test_shear_wall.py Removes unused test variables.
Testing/test_node_merge.py Removes unused test variables.
Testing/test_meshes.py Removes unused test variables.
Testing/test_mesh_regeneration.py Removes unused test variables.
Testing/test_mesh_regen_simple.py Removes unused test variables.
Testing/test_material_section_coverage.py Removes unused test variables.
Testing/test_analysis_regeneration.py Removes unused test variables.
ruff.toml Enables F841.
Pynite/Visualization.py Removes unused diagram locals.
Pynite/Rendering.py Removes unused rendering locals.
Pynite/FEModel3D.py Removes an unused displacement calculation.
Review details
  • Files reviewed: 11/11 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@JWock82
JWock82 commented Sep 16, 2026
Copy link
Copy Markdown
Owner

I'll have to look at this one closer. I'm noticing this deletes some unused variables that may be placeholders for future features.

@JWock82
JWock82 merged commit 88f62a5 into JWock82:main Oct 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0