Repository navigation
Conversation
_identify_piers, _identify_coupling_beams, and the material assignment step in generate() all iterated over self.model.quads.values(), i.e. every plate in the entire model rather than just this wall's own plates. When two shear walls have overlapping local x/y bounding boxes in their own coordinate frame (e.g. parallel walls at different origins), plates belonging to one wall were mistakenly appended to the other wall's piers, so sum_forces() reported inflated/duplicated shear, moment and axial values. Added ShearWall._wall_plates(), which scopes these loops to only the elements of this wall's own mesh (plus its flange meshes), and used it at all three call sites. Added a regression test with two parallel walls confirming each pier only picks up its own wall's plates. Fixes JWock82#335
Owner
|
I saw this after making the fix myself. Sorry to duplicate your efforts. Try |
Contributor
Author
|
No worries at all, glad it's already sorted in v3.1.0. Thanks for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShearWall._identify_piers,_identify_coupling_beams, and the material-assignment step ingenerate()all loop overself.model.quads.values()— every plate in the whole model — instead of only the plates belonging to that wall. The assignment then only checks a plate's local (x, y) against a pier's bounding box, ignoring the local z coordinate entirely, so when two shear walls are parallel and placed at different origins (e.g. two floors of the same wall line, or mirrored walls), a plate from one wall can fall inside another wall's pier bounding box and get double-counted.I reproduced the reporter's exact script: piers that should have been identical (
[4,0,0]vs[4,0,12], and[4,4,0]vs[4,4,12]) reported different V/M/P, andpier.platesvisibly accumulated more entries for later piers.Fix: added
ShearWall._wall_plates(), which returns only the elements from this wall's own mesh (self.model.meshes[self.name]) plus any of its flange meshes, and used it in place ofself.model.quads.values()in all three places. After the fix the previously-mismatched pier pairs report identical V/M/P, andpier.platesno longer grows across piers.Added a regression test (
test_pier_plates_are_wall_specific) with two parallel walls at different origins, asserting each pier only picks up its own wall's plates. Full existing test suite (179 passed, 1 skipped) still passes.Fixes #335