8000 Agent skills: dual-review and solve-issue by haizhongzheng · Pull Request #99 · Infini-AI-Lab/hermit · GitHub
[go: up one dir, main page]

Skip to content

Agent skills: dual-review and solve-issue - #99

Merged
haizhongzheng merged 1 commit into
mainfrom
agents/dual-review-solve-issue
Nov 10, 2026
Merged

haizhongzheng merged 1 commit into
mainfrom
agents/dual-review-solve-issue

Conversation

@haizhongzheng
Copy link
Copy Markdown
Member

Change

Adds two agent skills next to prepare-pr and post-pr-audit.

  • .agents/skills/dual-review/ (SKILL.md, codex-prompt.md): reviews a PR in rounds.
    • Each round, the session reviews the PR, and a fresh, read-only Codex session (gpt-6.1-sol, high effort) reviews it independently. The Codex prompt is codex-prompt.md.
    • The session merges the two lists, verifies every finding against the code (reproducing it where it can), and fixes the confirmed ones with a test that fails without the fix. It records the rest with a verdict: not a problem, disputed, uncertain, minor, not worth it, or out of scope.
    • The loop stops when a round finds nothing new that blocks the merge, or after 10 rounds. It ends with a report: merge verdict, rounds, changes, what was left and why, tests, and any agent-facing text changes for the user to approve.
    • Nothing is committed, pushed or posted without the user's word.
    • It fulfills the independent-review item of the general PR checklist (post-pr-audit).
  • .agents/skills/solve-issue/SKILL.md: takes an issue to a merged fix.
    1. Verify the issue against the code.
    2. Fix it in a fresh worktree, with tests that fail without the fix, run against a worktree of origin/main.
    3. Run the change-selected tests, build the docs and run lint.
    4. Open the PR by prepare-pr.
    5. Run dual-review.
    6. Push its fixes once the final tests pass and the user says so.
    7. Squash-merge after CI and the user's go-ahead, pinned to the tested head (--match-head-commit).
    8. Clean up the worktrees and branches.

Both have been used on this repository: dual-review on #49, #81, #88 and #94; solve-issue on #96 (→ #97) and #95 (→ #98). The frontmatter adds name:, as the existing skills have. user-invocable: true lets Claude Code offer them as /dual-review and /solve-issue.

Not changed: AGENTS.md still names prepare-pr and post-pr-audit only. Pointing it at these two is a separate wording decision.

Validation

  • python -m pytest --changed --base origin/main: no test group selected (only .agents/ files changed).
  • The files are copies of the versions used in the runs listed above. The only edit is the added name: line. They contain no personal paths or credentials.

Review

  • Tests and documentation cover the affected behavior, where applicable. These are agent instructions, so there is no code or test to change.
  • Commands, defaults, and public interfaces are consistent: gh, codex exec and pytest --changed, as in CONTRIBUTING.md and the existing skills.
  • Shared logs and examples contain no credentials or private data.
  • Documentation-only: requested by the core team in the session that used them. There is no separate issue.
  • Core changes. None.
  • This description. Read back against the diff.
  • Independent review (post-PR audit). Not run. Agent instructions only.

🤖 Generated with Claude Code

dual-review: two independent reviews of a PR each round (this session and a
fresh read-only Codex), every finding verified against the code, real ones
fixed with a test that fails without the fix, until a round finds nothing
that blocks the merge; minor points are recorded, not fixed.

solve-issue: an issue to a merged fix - verify the issue against the code,
fix it in a fresh worktree, open the PR by prepare-pr, run dual-review, push
its fixes once the final tests pass, squash-merge after CI and the user's
go-ahead, clean up.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@haizhongzheng
haizhongzheng merged commit 1b0d897 into main Nov 10, 2026
1 check passed
iamziyuzhao added a commit that referenced this pull request Nov 10, 2026
main gained #91 (the AHE Evolver's texts name a Pi or mini-swe-agent
acting agent's stream), #94 (OpenCode as a CLI Base Agent), #97
(hermit deploy retires skills the adapter no longer exports) and #99
(agent skills for this repository). #94 adds OpenCode at the places
this branch adds dsh, so 36 files conflicted. Each conflict keeps both
sides, OpenCode before dsh:

- CLIS, the readers (records.parse_log, trajectory's STREAM_HOSTS,
  READERS and MARKS, the AHE debugger's STREAM_TEXTS) and every list
  of CLIs name both, dsh last; cli.py's Dsh part follows OpenCode's;
- main's NO_LOGIN replaces this branch's tuples in login.py,
  isolate.py and acting/workspace.py, and gains "dsh";
- a comment that no longer fits 120 columns with both names is on
  its own line;
- docs: both names in each list. docs/methods/agent.md's dsh learner
  now "signs in as the pi learner does", since OpenCode's sentence
  stands between them; in docs/methods/ahe_adapter.md, #91's general
  wording ("the one its CLI wrote") replaces this branch's list of
  streams.

dsh does not call #97's check_skills and retire_skills yet; the next
commit does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@haizhongzheng
haizhongzheng deleted the agents/dual-review-solve-issue branch November 10, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0