Repository navigation
Fix heuristic solver boundary handling - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Several solver paths assumed node identifiers were contiguous integer array positions, while component-based traversal stopped after the first connected component. Iterative rankers also lacked input validation and convergence bounds, allowing invalid configurations to produce NaN/inf values or loop indefinitely.
Impact
All 11 registered heuristic solvers now support the advertised grid topology and arbitrary hashable node IDs. Incomplete mappings can no longer be reported as successful, and invalid rank configurations fail with actionable errors. Default connected integer-ID behavior and solver acceptance counts remain unchanged.
Validation
.venv/bin/pytest -q— 204 passed.venv/bin/python -m compileall -q virne testsgit diff --check