8000 Fix heuristic solver boundary handling by GeminiLight · Pull Request #48 · GeminiLight/virne · GitHub
[go: up one dir, main page]

Skip to content

Fix heuristic solver boundary handling - #48

Merged
GeminiLight merged 1 commit into
mainfrom
agent/fix-heuristic-boundaries
Aug 10, 2026
Merged

GeminiLight merged 1 commit into
mainfrom
agent/fix-heuristic-boundaries

Conversation

@GeminiLight
Copy link
Copy Markdown
Owner

Summary

  • support tuple and non-contiguous node identifiers throughout network lookup and candidate filtering
  • make PL and RW-BFS process every virtual-network component and reject incomplete mappings
  • stabilize random, GRC, RW, NPS, and link-order ranking behavior
  • validate iterative ranking parameters and fail explicitly on non-convergence
  • add regression coverage for grid topology, arbitrary IDs, disconnected VNs, zero resources, and invalid rank parameters

Root cause

Several solver paths assumed node identifiers were contiguous integer array positions, while component-based traversal stopped after the first connected component. Iterative rankers also lacked input validation and convergence bounds, allowing invalid configurations to produce NaN/inf values or loop indefinitely.

Impact

All 11 registered heuristic solvers now support the advertised grid topology and arbitrary hashable node IDs. Incomplete mappings can no longer be reported as successful, and invalid rank configurations fail with actionable errors. Default connected integer-ID behavior and solver acceptance counts remain unchanged.

Validation

  • .venv/bin/pytest -q — 204 passed
  • .venv/bin/python -m compileall -q virne tests
  • git diff --check
  • 440 randomized solver/property runs with no resource leaks or invalid solutions
  • all 11 heuristic CLI flows
  • PL and NEA multi-resource CLI flows
  • NRM grid_2d end-to-end flow
  • default GRC/RW/random ordering compatibility checks

@GeminiLight
GeminiLight merged commit 046bab9 into main Aug 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0