8000 Fix network simulation correctness and accounting by GeminiLight · Pull Request #47 · GeminiLight/virne · GitHub
[go: up one dir, main page]

Skip to content

Fix network simulation correctness and accounting - #47

Merged
GeminiLight merged 1 commit into
mainfrom
agent/fix-network-simulation-correctness
Aug 9, 2026
Merged

GeminiLight merged 1 commit into
mainfrom
agent/fix-network-simulation-correctness

Conversation

@GeminiLight
Copy link
Copy Markdown
Owner

Summary

  • correct virtual-network event timing, Poisson arrival generation, legacy event normalization, and topology parameter semantics
  • make mapping, resource updates, deployment, and release transactional and validate solver output before physical-network mutation
  • fix recorder/counter indexing and accounting for non-contiguous IDs, multiple resources, time-weighted metrics, and constraint violations
  • explicitly reject unsupported reusable mappings and time-window mode instead of producing unreliable results
  • add focused regression coverage across core environment, mapping, resources, topology, and dataset compatibility

Root cause

Several simulator layers relied on implicit assumptions: IDs matched list positions, equal-time arrivals ran before departures, resource updates could partially mutate state, and accounting formulas assumed a single resource. These assumptions could change admission outcomes or reported metrics without an explicit error.

Impact

The core simulation now uses [arrival, departure) service intervals, preserves physical-network state on invalid solutions or failed deployments, supports legacy datasets through normalization, and reports consistent metrics across resource dimensions. Unsupported modes fail fast with actionable errors.

Validation

  • .venv/bin/pytest -q — 179 passed
  • .venv/bin/python -m compileall -q virne tests
  • git diff --cached --check
  • end-to-end NRM and all 11 registered heuristic solvers on small simulations
  • save-enabled CSV output flow

@GeminiLight
GeminiLight merged commit 0a948f6 into main Aug 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0