Repository navigation
Fix network simulation correctness and accounting - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Several simulator layers relied on implicit assumptions: IDs matched list positions, equal-time arrivals ran before departures, resource updates could partially mutate state, and accounting formulas assumed a single resource. These assumptions could change admission outcomes or reported metrics without an explicit error.
Impact
The core simulation now uses
[arrival, departure)service intervals, preserves physical-network state on invalid solutions or failed deployments, supports legacy datasets through normalization, and reports consistent metrics across resource dimensions. Unsupported modes fail fast with actionable errors.Validation
.venv/bin/pytest -q— 179 passed.venv/bin/python -m compileall -q virne testsgit diff --cached --check