8000 fix: give the Shortcut the confirmation page's full URL by DArtagan · Pull Request #25 · DArtagan/bookdrop · GitHub
[go: up one dir, main page]

Skip to content

fix: give the Shortcut the confirmation page's full URL - #25

Merged
DArtagan merged 1 commit into
mainfrom
shortcut-url
Nov 7, 2026
Merged

DArtagan merged 1 commit into
mainfrom
shortcut-url

Conversation

@DArtagan
@DArtagan DArtagan commented Nov 7, 2026
Copy link
Copy Markdown
Owner

On the phone the Shortcut opened bookdrop's front page: joining the returned path to the address produced the address alone. /drop now returns the full URL (scheme from X-Forwarded-Proto, which the internal ingress sets), and the Shortcut opens it as is. Squash; the phone's Shortcut needs steps 4 to 6 rebuilt from /shortcut.

On the phone, the Shortcut opened bookdrop's front page rather than the
drop's confirmation page: the step joining the returned path to the
address had produced the address alone. /drop now answers a JSON client
with the full URL, taking the scheme from X-Forwarded-Proto behind the
ingress, and the Shortcut opens it as it is, one step fewer to build.
The /shortcut page names the scheme the same way.
@DArtagan DArtagan left a comment
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, let's test.

@DArtagan
DArtagan merged commit 56e095b into main Nov 7, 2026
2 checks passed
@DArtagan
DArtagan deleted the shortcut-url branch November 7, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0