Repository navigation
Conversation
… app protocol. Signed-off-by: Brian Rosenfield <brosenfi@yahoo.com>
|
what is the motivation for these changes? |
|
Hi @sunsingerus - adding the ability to run this operator within istio enabled clusters. We have noticed without these name changes that istio / envoy is not auto-detecting the protocols successfully in our environment ( see this description concerning istio's app protocol selection and app protocol selection as part of the name). |
|
@brosenfi thanks for the PR, but we will not merge it, reasons
Istio apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
name: demo
spec:
defaults:
templates:
serviceTemplate: chi-svc
replicaServiceTemplate: host-svc
templates:
serviceTemplates:
- name: chi-svc
spec:
type: ClusterIP
clusterIP: None
ports:
- { name: http, port: 8123, targetPort: http, appProtocol: http }
- { name: tcp, port: 9000, targetPort: tcp, appProtocol: tcp }
- name: host-svc
spec:
type: ClusterIP
clusterIP: None
publishNotReadyAddresses: true
ports:
- { name: http, port: 8123, appProtocol: http }
- { name: tcp, port: 9000, appProtocol: tcp }
- { name: interserver, port: 9009, appProtocol: http }
# secure: yes
# - { name: https, port: 8443, appProtocol: https }
# - { name: secureclient, port: 9440, appProtocol: tls }apiVersion: clickhouse-keeper.altinity.com/v1
kind: ClickHouseKeeperInstallation
metadata:
name: keeper
spec:
defaults:
templates:
serviceTemplate: chk-svc
templates:
serviceTemplates:
- name: chk-svc
spec:
type: ClusterIP
clusterIP: None
ports:
- { name: zk, port: 2181, targetPort: zk, appProtocol: tcp }
- { name: raft, port: 9444, targetPort: raft, appProtocol: tcp }
for existing feel free to reopen if you still have questions |
Update default port names to more Istio friendly names indicating the app protocol.
Note I did not update the "interserver" port name as there appears to be indirectly linked references (within the operator) using that name - I had a local deployment fail when updating this name to "http-interserver". Also, istio's app protocol auto-detection seems to work fine for this interserver connection.