8000 fix: itemsadder block drops [EcoHub-592] by Exanthiax · Pull Request #686 · Auxilor/eco · GitHub
[go: up one dir, main page]

Skip to content

fix: itemsadder block drops [EcoHub-592] - #686

Merged
Exanthiax merged 1 commit into
masterfrom
fix/itemsadder-block-drops
Nov 13, 2026
Merged

Exanthiax merged 1 commit into
masterfrom
fix/itemsadder-block-drops

Conversation

@Exanthiax
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
coderabbitai Bot commented Nov 11, 2026
Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

ItemsAdderProvider now constructs ItemsAdder custom blocks with hardness -1f and a loot callback. The callback requests loot with the provided tool, or an AIR item when no tool is provided. It returns an empty list if the loot request throws. Existing lookup, ID matching, and placement behaviour remains in place.

Merge Risk: Minimal · up to c8656

This change gives ItemsAdder blocks explicit hardness and a tool-aware drop calculation. No concrete defect was established, so it looks safe to merge.

Security architecture risk: Low · up to c8656

The change is confined to ItemsAdder drop calculation. No new access-control bypass is demonstrated, but the external loot method and downstream automated consumers could not be fully assessed.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The demonstrated exposure is changed loot behavior for consumers requesting ItemsAdder custom-block drops through TestableBlock. The available evidence does not establish the full runtime caller population or downstream effects of the returned items.

Trust Boundaries and Controls

  • observed — The provider retains its captured-ID matching predicate. The loot callback resolves the supplied world block without repeating that comparison, while the public contract places the matching-block precondition on callers. This alone does not establish a reachable identity bypass.

Resilience and Maintainability Implications

  • observed — An exception from getLoot produces an empty drop list rather than vanilla fallback. If placed-block lookup returns null, the callback instead returns null. These are distinct failure outcomes; the exception handling is not evidence of an authorization control.
Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 78538c42-8b83-47d1-ba71-1ed4d0fe1f9d
Commits

Reviewing files that changed from the base of the PR and between 863fe9a and c865606.

Files selected for processing: 1

  • eco-core/core-plugin/src/main/kotlin/com/willfp/eco/internal/spigot/integrations/customblocks/CustomBlocksItemsAdder.kt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@Exanthiax
Exanthiax merged commit 5adb396 into master Nov 13, 2026
4 checks passed
@Exanthiax
Exanthiax deleted the fix/itemsadder-block-drops branch November 13, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0