Repository navigation
test: isolate combat state between runs - #94
Conversation
|
Warning Review limit reached
Next review available in: 42 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Health of changed files: 1.0 (unchanged) 📋 At a glance ✅ Health gate: passed 📌 Before you merge
🔎 More signals (3)🗺️ Change map flowchart LR
subgraph PR ["Changed in this PR (1 with dependents)"]
f_src_server_handlers_combat_handlers_ts[".../handlers/combat-handlers.ts 🔥"]:::changed
end
f_src_server_consolidated_combat_action_ts[".../consolidated/combat-action.ts"]
f_src_server_handlers_combat_handlers_ts --> f_src_server_consolidated_combat_action_ts
f_src_server_consolidated_combat_manage_ts[".../consolidated/combat-manage.ts"]
f_src_server_handlers_combat_handlers_ts --> f_src_server_consolidated_combat_manage_ts
f_src_server_consolidated_combat_map_ts[".../consolidated/combat-map.ts"]
f_src_server_handlers_combat_handlers_ts --> f_src_server_consolidated_combat_map_ts
t_tests_server_combat_action_log_test_ts(["✅ tests/server/combat-action-log.test.ts"]):::guard
t_tests_server_combat_action_log_test_ts -.-> f_src_server_handlers_combat_handlers_ts
classDef changed fill:#dbeafe,stroke:#1d4ed8,color:#1e3a5f
classDef warn fill:#fef3c7,stroke:#b45309,color:#78350f
classDef guard fill:#dcfce7,stroke:#15803d,color:#14532d
Solid arrows: code that imports the changed files (3 direct dependents, from the last indexed snapshot). Dashed: history/tests. 🔥 Hotspot touched (1)
💀 Dead code (2 findings)
📊 See the full report for this PR |
What changed\n\nMake the existing test helper clear the process-wide CombatManager singleton.\n\n## Root cause\n\nclearCombatState() was a no-op, so encounters leaked between test files. In the post-merge CI schedule, the combat_manage death-save alias test could lose its in-memory encounter and receive an error object without success.\n\n## Validation\n\n-
pm run build\n-
pm run test:ci\n- 143 test files passed, 1 skipped\n- 2,245 tests passed, 7 skipped\n- focused combat tests: 84 passed\n\nFixes the post-merge CI failure from run 31824782824.