Repository navigation
Merged
Conversation
SRD-compliant probabilistic test with retry mechanism
Production
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this sugge
309C
stion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability and clarity of the "successful save halves damage" test for Fireball in the spellcasting test suite. The test now uses a retry mechanism to reduce flakiness due to randomness and ensures that the wizard's spell slot usage matches SRD constraints. Additionally, the random seed is made unique per retry to further reduce the chance of repeated failures.
Test reliability and determinism improvements:
retry: 5) to the Fireball save test to minimize flakiness from random number generation, and updated comments to clarify the probability of test failure.handleCreateEncounterto include a timestamp, ensuring each retry uses a different RNG sequence.Test logic and clarity improvements: