8000 fix(equipment): a burglar's pack holds one 2 lb bag of ball bearings by Mnehmos · Pull Request #112 · Mnehmos/mnehmos.rpg.mcp · GitHub
[go: up one dir, main page]
Skip to content

fix(equipment): a burglar's pack holds one 2 lb bag of ball bearings - #112

Merged
Mnehmos merged 1 commit into
mainfrom
fix/ball-bearings-weight
Oct 25, 2026
Merged

fix(equipment): a burglar's pack holds one 2 lb bag of ball bearings#112
Mnehmos merged 1 commit into
mainfrom
fix/ball-bearings-weight

Conversation

@Mnehmos
@Mnehmos Mnehmos commented Oct 25, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Owner

Why

Playtest: a new rogue (Mara Venn) showed 1068 / 165 lb carried. The Burglar's Pack listed 'Ball Bearings x1000'. That name doesn't match the Open5e catalog, so ensureItemExists created an ad-hoc item at the 1 lb fallback weight and granted 1,000 of them. Every rogue, and anyone choosing a Burglar's Pack, started about 1,000 lb over capacity.

Changes

  • The entry now names the SRD item, 'Ball Bearings (bag of 1000)', which resolves from the catalog as one 2 lb bag (quantity 1).
  • New tests/services/starting-equipment.service.test.ts: a provisioned rogue gets one 2 lb bag, and the starting kit totals under 150 lb.

Not changed (noted)

A few other pack entries also miss the catalog and use the 1 lb fallback: candles, pitons, parchment, paper, oil, incense. They're off by a few pounds at most, not a functional problem.

Existing characters keep their 1,000 one-pound bearings. That needs a separate data fix in the production engine database.

Verification

  • Both new tests fail on main and pass with the fix.
  • npx vitest run tests/services tests/server/consolidated/inventory-manage.test.ts tests/server/consolidated/character-manage*.test.ts tests/server/expanded-features.test.ts: 166 passed. npx tsc --noEmit -p .: clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • The burglar’s starting equipment now labels the item as “Ball Bearings (bag of 1000),” clarifying that it is one bag containing 1,000 ball bearings rather than an ambiguous “x1000” entry. This makes the equipment list easier to understand when reviewing the character’s starting inventory.

@Mnehmos @claude
fix(equipment): a burglar's pack holds one 2 lb bag of ball bearings
ba17f09 
'Ball Bearings x1000' did not match the Open5e catalog, so starting
equipment created an ad-hoc item at the 1 lb fallback weight and granted
1,000 of them: every rogue (and anyone taking a burglar's pack) started
about 1,000 lb over. The entry now names the SRD item, "Ball Bearings
(bag of 1000)", which resolves from the catalog as one 2 lb bag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 25, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T20:24:29.726638Z ba17f09 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai
coderabbitai Bot commented Oct 25, 2026 •
edited
Loading
Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The burglar pack entry now identifies the ball bearings as a bag of 1000. Integration tests check the provisioned bag’s weight and quantity, and the rogue’s total carried weight.

Changes: Rogue Starting Equipment

Layer / File(s) Summary
Pack item and provisioning test
src/data/class-starting-data.ts, tests/services/starting-equipment.service.test.ts		 The burglar pack entry is renamed to Ball Bearings (bag of 1000). Tests verify that a level-1 rogue receives one 2 lb bag and has total carried weight below 150 lb.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · up to ba17f

The change is ready to merge; no actionable current-head risk was identified.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mnehmos
Mnehmos merged commit 3061221 into main Oct 25, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Mnehmos
0