(btw there are some border crossing routing integration tests in libs/routing/routing_integration_tests/route_test.cpp already - it could be a good idea to review them)
As @x7z4w rightly noted, there is a separate penalty (or no penalty at all) for "internal" EU borders.
I'd say on these screenshots the viewpoint icon looks good against the greenery. But the gates icon blends in with tracks/trails too much still (and it'll be worse on a real device where the icon…
I'd say for tracks it should be 3 grades max (similar to hiking trails grades).
Yeap its a similar approach but with a denser pattern (we can test various options!)
I mean when track recording is active, how is it highlighted in the menu and on the left-side main button? (screenshots)
E.g. a bog is a part of the forest. But its distinct enough so that we want it seen clearly on the map.
Yeah, basically this extra (compared to e.g. UI translations) approval is needed to ensure that the syntax is being followed and the changes won't break the search.
So it looks like a duplicate or a subset of comaps/comaps#1372
And of course it'd be great to be consistent across platforms!
I think red haven't been initially used there because its way too bright.
@bmgru thanks a lot for this investigation! Could you please raise a PR to fix it?
The background for e.g. settings card pop-up is back to white now, thanks!
And we can consider just concealing the "private internal" option (if the "shared" one is present also).
A related good UX improvement would be to better handle out-of-free-space errors - if there is another storage with more free space available then ask the user to review storage settings.
- We should keep the preference of "shared" over the "private".
The logic was to choose the storage with the most free space and prefer "shared" internal storage over the "private" internal storage (they're same physically so have same free space).