Use XPCOMUtils.generateQI in connection-xpcom in cZ
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
|
1.28 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Make use of XPCOMUtils.generateQI helper in cZ's connection-xpcom.js file.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Updated•7 months ago
|
Comment 2•7 months ago
|
||
Comment on attachment 9445753 [details] [diff] [review]
1939930-irc-xpcom-generateQI-25321.patch
lgtm r/a+
Not sure if querying Ci.nsISupports is still needed here but doesn't hurt an too too lazy to test :)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/df2aac18b09e
Use XPCOMUtils.generateQI in connection-xpcom in cZ. r=frg DONTBUILD
Comment 4•2 months ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/85c0578d80b36522ff9abd91126b45d8ba28d2d6
Use XPCOMUtils.generateQI in connection-xpcom in cZ. r=frg a=frg
Description
•