Repository navigation
Conversation
- rate_limit: the docs said the test venue enforces the stated terms; it meters nothing. Now says a venue refuses past them, and SimVenue doesn't. - Venue: what to stamp recv_time with (requests.with_time()), who refuses a malformed request (the venue, as Invalid) versus Other, and how an immediate-or-cancel order is answered. - Order/Fill side say Bid for a buy and Ask for a sell; ClientOrderId says one id is one order. - PositionOps: a mark moving does not run the node; value at the marks by joining them to the reading. - StreamOps::map takes the value by reference; ticker's first tick is at the run's start. - scripts/disk.sh auto stands down while cargo or rustc is running: it was deleting registry sources and target/*/examples under builds in flight, which four of run 2's agents lost compiles to. - The skill records what run 2 taught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XZD1qMp5oESgFaJBhiVFc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This fixes what the second
/dogfood-executionrun found. It is one commit, mostly docs, plus one script fix.Defects
rate_limit's module docs said "the sim enforces the stated terms whole". It doesn't: nothing intesting.rsorfix.rsemitsRateLimited, and there is no way to give the sim a rate. The run's limits agent had a failing repro. The docs now say a venue refuses past its terms, and that the test venue meters nothing.scripts/disk.sh autobroke builds that were in flight. It runs after every Bash call in a Claude Code session, and it deleted~/.cargo/registry/srcandtarget/*/examplesunder builds still running: background jobs, parallel agents, the pre-push hook. Four of run 2's eight agents lost compiles to it ("failed to download … No such file"). It now stands down whilecargoorrustcis running; an explicitlightordeepstill runs.Docs
Venuenow covers what to stamprecv_timewith (requests.with_time()), that a malformed request is the venue's to refuse asInvalid(versusOtherfor one it understands and declines), and how an immediate-or-cancel order is answered.Order::side/Fill::sidesaid "Buy or sell", but the type isSide::Bid/Side::Ask. Three agents triedSide::Buy.ClientOrderIdnow says one id is one order, and what happens if a hand-built caller reuses one.PositionOps: a mark moving doesn't run the node, so the docs now say to value at the marks with a join, as theposition_bookexample does.StreamOps::maptakes the value by reference (four agents hit this).ticker's first tick is at the run's start.U7 (
Pacingcan't say which limit held which request) is an API question, filed as #1067.Why
Run 2 re-ran run 1's eight stories, worded the same, against the docs #1065 fixed. None of the eight agents needed an example (run 1: all eight did). These are what was still left.
How it was verified
cargo fmt --all -- --checkcargo doc -p wingfoil --no-deps --features execution-testing: 102 warnings before and after, so no new broken linksdisk.sh autochecked by hand: it skips while a process namedcargoruns, and cleans once it's gonean_ioc_that_does_not_cross_is_cancelledand the duplicate-id line against the run-2 probe.Before you submit
Generated by Claude Code