Repository navigation
fix(linker-diff): ignore .got.plt sh_entsize by default - #2914
Open
deepakshirkem wants to merge 1 commit into
Open
deepakshirkem wants to merge 1 commit into
deepakshirkem wants to merge 1 commit into
Conversation
Wild sets sh_entsize to 8 for .got.plt, as it does for .got and .plt, while GNU ld and lld leave it 0. 23 tests already ignored this individually; remove those now that --wild-defaults covers it.
deepakshirkem
marked this pull request as ready for review
November 6, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wild sets
sh_entsizeto 8 for.got.plt, as it already does for.gotand.plt(both in--wild-defaults), while GNU ld and lld leave it 0. This showed up in every Rust link checked withWILD_REFERENCE_LINKER=ld.23 tests already ignored this with
DiffIgnore, including some diffed against lld; this removes those, and they now pass via the default instead. Without the new default, 29 x86_64 and 19 aarch64 test configs fail withsection.got.plt.entsize, e.g.hash-style,shared/symbolic-non-weakandifunc-shared/lld.Part of #2380