8000 chore: Include wasm in list of flavors by davidlattimore · Pull Request #2903 · wild-linker/wild · GitHub
[go: up one dir, main page]
Skip to content

chore: Include wasm in list of flavors #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidlattimore merged 1 commit into from
Nov 6, 2026
Merged

chore: Include wasm in list of flavors #2903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions libwild/src/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ pub const EXPERIMENTAL_PLATFORMS: &str = "WILD_EXPERIMENTAL_PLATFORMS";
/// spinlock. By the time we reach 128 threads, we're spending about 56% of time in that spinlock.
const DEFAULT_THREAD_CAP: NonZeroUsize = NonZeroUsize::new(32).unwrap();

const SUPPORTED_FLAVORS: &str = "gnu, wasm, darwin, link";

#[derive(derive_more::Debug)]
pub struct CommonArgs {
pub(crate) unrecognized_options: Vec<String>,
Expand Down Expand Up @@ -136,7 +138,7 @@ impl Args {

let flavor = input
.next()
.context("-flavor requires an argument (gnu, darwin, or link)")?;
.with_context(|| format!("-flavor requires an argument ({SUPPORTED_FLAVORS})"))?;

PlatformKind::from_flavor(flavor.as_ref())?
} else if let Some(platform) = PlatformKind::from_executable_name(prog_name.as_ref()) {
Expand Down Expand Up @@ -266,10 +268,7 @@ impl PlatformKind {
"darwin" | "ld64" => Ok(PlatformKind::MachO),
"link" => Ok(PlatformKind::Coff),
"wasm" | "ld-wasm" => Ok(PlatformKind::Wasm),
_ => bail!(
"Unknown flavor '{}'. Valid flavors: gnu, darwin, link",
flavor
),
_ => bail!("Unknown flavor '{flavor}'. Valid flavors: {SUPPORTED_FLAVORS}",),
}
}

Expand Down
Loading
0