Repository navigation
refactor: Remove old background file creation code - #2908
Open
davidlattimore wants to merge 1 commit into
Open
davidlattimore wants to merge 1 commit into
davidlattimore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into how best to handle things like properly sizing the trie in our Mach-O output and realised that we weren't actually benefiting from any parallelism with file creation due to compressed debug info sizing pushing the start of file creation later. I contemplated if we should restore the parallelism, at least when compressed debug info isn't enabled, but the potential gains looked pretty small, so I figured we'd be better of just getting rid of this bit of complexity, at least for now.