8000 Add #include <optional> by amarburg · Pull Request #41 · waterlinked/waterlinked_dvl · GitHub
[go: up one dir, main page]
Skip to content

Add #include <optional> - #41

Open
amarburg wants to merge 1 commit into
waterlinked:mainfrom
apl-ocean-engineering:dev/add_include_optional
Open

Add #include <optional>#41
amarburg wants to merge 1 commit into
waterlinked:mainfrom
apl-ocean-engineering:dev/add_include_optional

Conversation

@amarburg
@amarburg amarburg commented Sep 2, 2026
Copy link
Copy Markdown

Changes Made

When building in a custom Jazzy / 22.04 ROS build (built using jetson-containers), I get this warning:

In file included from /home/ubuntu/odometry_nano_ws/src/waterlinked_dvl/libwaterlinked/include/libwaterlinked/client.hpp:35,
                 from /home/ubuntu/odometry_nano_ws/src/waterlinked_dvl/libwaterlinked/src/client.cpp:21:
/home/ubuntu/odometry_nano_ws/src/waterlinked_dvl/libwaterlinked/include/libwaterlinked/protocol.hpp:160:8: error: ‘optional’ in namespace ‘std’ does not name a template type
  160 |   std::optional<bool> hardware_trigger_enabled;
      |        ^~~~~~~~
/home/ubuntu/odometry_nano_ws/src/waterlinked_dvl/libwaterlinked/include/libwaterlinked/protocol.hpp:27:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
   26 | #include <nlohmann/json.hpp>
  +++ |+#include <optional>
   27 |

Adding #include <optional> to protocol.hpp resolves the issue.

Testing

Driver successfullly builds with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@amarburg
0