Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13bf77c138
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Adds NI-XNET discovery and CAN/CAN FD frame streams on Windows x64, using the installed runtime without a C compiler or Python dependency. Reuses the existing capture, lifecycle and conformance contracts, with non-blocking queue acceptance, controller events, explicit frame restrictions and exact FD timing. Adds switchable termination and channel-specific 500k/2M and 500k/4M presets.
The shared API additions are Config.Termination and Channel.SupportsTermination. The zero value preserves existing driver behaviour and keyed Config literals remain compatible; positional Config literals need updating for the added field. The Bus interface is unchanged. Existing PCAN, Vector and SocketCAN configuration paths retain their defaults.
Validation: go test -race ./..., go vet ./..., gofmt and diff checks pass, as do Windows amd64, arm64 and 386 compilation checks. Reviewed against python-can and NI's reference implementation. Developed against real NI hardware; further cross-driver hardware testing is pending. NI-XNET remains Windows x64 only, with documented restrictions on ESI, classical DLC and timing.
Related to #14.