8000 drivers: add NI-XNET CAN and CAN FD streams by tomrford · Pull Request #93 · tomrford/gocan · GitHub
[go: up one dir, main page]

Skip to content

drivers: add NI-XNET CAN and CAN FD streams - #93

Merged
tomrford merged 3 commits into
mainfrom
nixnet
Oct 2, 2026
Merged

tomrford merged 3 commits into
mainfrom
nixnet

Conversation

@tomrford
@tomrford tomrford commented Oct 2, 2026
Copy link
Copy Markdown
Owner

Adds NI-XNET discovery and CAN/CAN FD frame streams on Windows x64, using the installed runtime without a C compiler or Python dependency. Reuses the existing capture, lifecycle and conformance contracts, with non-blocking queue acceptance, controller events, explicit frame restrictions and exact FD timing. Adds switchable termination and channel-specific 500k/2M and 500k/4M presets.

The shared API additions are Config.Termination and Channel.SupportsTermination. The zero value preserves existing driver behaviour and keyed Config literals remain compatible; positional Config literals need updating for the added field. The Bus interface is unchanged. Existing PCAN, Vector and SocketCAN configuration paths retain their defaults.

Validation: go test -race ./..., go vet ./..., gofmt and diff checks pass, as do Windows amd64, arm64 and 386 compilation checks. Reviewed against python-can and NI's reference implementation. Developed against real NI hardware; further cross-driver hardware testing is pending. NI-XNET remains Windows x64 only, with documented restrictions on ESI, classical DLC and timing.

Related to #14.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 2, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T17:17:12.201262Z b306fd9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13bf77c138

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tomrford commented Oct 2, 2026
Copy link
Copy Markdown
Owner Author

@codex review

Please review the current head b306fd9. The previous discovery finding was checked against NI's reference: 0x06110004 is CAN-only NX_PROP_SYS_INTF_REFS_CAN. The constant is now named propCANInterfaces with its native identity documented; see the resolved thread for source evidence.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: b306fd98b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@tomrford
tomrford merged commit c6aafd6 into main Oct 2, 2026
1 check passed
@tomrford
tomrford deleted the nixnet branch October 2, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0