8000 dbc: distinguish inactive signals during payload decoding by tomrford · Pull Request #92 · tomrford/gocan · GitHub
[go: up one dir, main page]

Skip to content

dbc: distinguish inactive signals during payload decoding - #92

Merged
tomrford merged 1 commit into
mainfrom
dbc/inactive-signal
Oct 1, 2026
Merged

tomrford merged 1 commit into
mainfrom
dbc/inactive-signal

Conversation

@tomrford
@tomrford tomrford commented Oct 1, 2026
Copy link
Copy Markdown
Owner

Decoding a signal excluded by the selected multiplexing path currently returns an unclassified error. Short payloads can also report missing branch bytes even when a present ancestor selector already proves that the branch is inactive.

Add dbc.ErrInactiveSignal, wrapped with the signal name by DecodePayload and propagated through Decode. Payload decoding walks selectors from the root, stops at an excluded branch, and requires signal bits only for active signals. Missing bytes needed to determine activity or decode an active signal remain failures; frame validation is unchanged.

Extend the existing multiplex lifecycle test with sentinel checks through both APIs, nested branch exclusion, short payloads, and rejected boundaries. No new test functions or fixtures.

Validation: go test -race ./..., go vet ./..., gofmt -l ., git diff --check, and Windows compile checks for amd64, arm64, and 386 all passed.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 1, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T19:11:00.276946Z c52884e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tomrford
tomrford merged commit d35e092 into main Oct 1, 2026
1 check passed
@tomrford
tomrford deleted the dbc/inactive-signal branch October 1, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3721

1 participant

0