Repository navigation
dbc: distinguish inactive signals during payload decoding - #92
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a signal excluded by the selected multiplexing path currently returns an unclassified error. Short payloads can also report missing branch bytes even when a present ancestor selector already proves that the branch is inactive.
Add
dbc.ErrInactiveSignal, wrapped with the signal name byDecodePayloadand propagated throughDecode. Payload decoding walks selectors from the root, stops at an excluded branch, and requires signal bits only for active signals. Missing bytes needed to determine activity or decode an active signal remain failures; frame validation is unchanged.Extend the existing multiplex lifecycle test with sentinel checks through both APIs, nested branch exclusion, short payloads, and rejected boundaries. No new test functions or fixtures.
Validation:
go test -race ./...,go vet ./...,gofmt -l .,git diff --check, and Windows compile checks for amd64, arm64, and 386 all passed.