8000 uds: return optional responses from suppressed exchanges by tomrford · Pull Request #89 · tomrford/gocan · GitHub
[go: up one dir, main page]

Skip to content

uds: return opti 8000 onal responses from suppressed exchanges - #89

Merged
tomrford merged 1 commit into
mainfrom
uds/do-suppressed
Sep 25, 2026
Merged

tomrford merged 1 commit into
mainfrom
uds/do-suppressed

Conversation

@tomrford
Copy link
Copy Markdown
Owner

Suppressed requests can still receive positive replies, including the final response after ResponsePending. SendAwaitNRC discarded those payloads, preventing callers from distinguishing a received response from initial silence.

Replace it with DoSuppressed(ctx, request) (*Response, error). Initial P2 silence returns (nil, nil); a positive reply returns its response and payload; a final negative reply returns NegativeResponseError. P2* timeouts, caller cancellation/deadlines, malformed replies and transport failures remain errors. The caller still supplies the suppression bit. The implementation reuses Do and removes the internal silence-policy flag.

This is a source-breaking API change: migrate err := client.SendAwaitNRC(ctx, request) to response, err := client.DoSuppressed(ctx, request), or _, err := ... when the response is not needed.

The existing lifecycle test now checks immediate and post-pending positive payloads, distinguishes a positive response with empty data from silence, and checks malformed replies alongside existing negative-response, timeout, cancellation, retention and transport-failure cases.

Validation: go test -race ./..., go vet ./..., gofmt -l ., git diff --check, and Windows amd64/arm64/386 compilation passed. No physical ECU validation.

Diff: production +20/−20; tests +16/−6.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 25, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T08:43:45.999118Z 06c76c4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tomrford
tomrford merged commit 4e6ca02 into main Sep 25, 2026
1 check passed
@tomrford
tomrford deleted the uds/do-suppressed branch September 25, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet
3AEF

Development

Successfully merging this pull request may close these issues.

1 participant

0