Repository navigation
uds: return opti 8000 onal responses from suppressed exchanges - #89
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppressed requests can still receive positive replies, including the final response after ResponsePending. SendAwaitNRC discarded those payloads, preventing callers from distinguishing a received response from initial silence.
Replace it with
DoSuppressed(ctx, request) (*Response, error). Initial P2 silence returns(nil, nil); a positive reply returns its response and payload; a final negative reply returnsNegativeResponseError. P2* timeouts, caller cancellation/deadlines, malformed replies and transport failures remain errors. The caller still supplies the suppression bit. The implementation reusesDoand removes the internal silence-policy flag.This is a source-breaking API change: migrate
err := client.SendAwaitNRC(ctx, request)toresponse, err := client.DoSuppressed(ctx, request), or_, err := ...when the response is not needed.The existing lifecycle test now checks immediate and post-pending positive payloads, distinguishes a positive response with empty data from silence, and checks malformed replies alongside existing negative-response, timeout, cancellation, retention and transport-failure cases.
Validation:
go test -race ./...,go vet ./...,gofmt -l .,git diff --check, and Windows amd64/arm64/386 compilation passed. No physical ECU validation.Diff: production +20/−20; tests +16/−6.