Repository navigation
uds: separate NRC waiting and distinguish transmit retry exhaustion - #88
Merged
Merged
Conversation
Send, SendTesterPresent and SendECUReset are send-only again; callers that want a suppressed request's negative response use SendAwaitNRC.
…P retry timeouts gocan.Send and cyclic's next-occurrence bound now end retries with the queue-full rejection alone, so callers no longer see context.DeadlineExceeded for a deadline they did not set. isotp.New and NewFunctional reject a negative TransmitRetryTimeout at construction.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate suppressed UDS sends into
SendandSendAwaitNRC, making response waiting explicit at the call site while reusing the existing exchange loop. Initial P2 silence succeeds; ResponsePending still requires a final response within P2*.This changes the public signatures: replace
Send(ctx, request, false)withSend(ctx, request)andSend(ctx, request, true)withSendAwaitNRC(ctx, request).SendTesterPresentandSendECUResetbecome send-only and lose their boolean argument; waiting callers useSendAwaitNRCwith the corresponding suppressed request.Transmit retry-budget exhaustion, including the next cyclic occurrence, returns the last queue rejection without a misleading caller-deadline error. Caller cancellation/deadlines remain distinguishable. Preserve that rejection when expiry occurs inside a driver call, while retaining definite acceptance. Both ISO-TP constructors now reject negative retry timeouts.
Validation:
go test -race ./...,go vet ./...,gofmt -l .,git diff --check, and Windows amd64/arm64/386 compilation passed. The added driver-expiry regression failed before the fix and passes afterwards. Existing lifecycle tests cover suppressed silence, final NRCs, pending completion/timeouts, cancellation, retention, and Flow Control failure. No physical hardware validation.Diff size: production +63/−47 (net +16); tests +43/−25 (net +18).