Repository navigation
8000 uds: add service variants and suppressed-response waiting - #85
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tomrford
force-pushed
the
uds/service-variants
branch
from
September 24, 2026 12:50
7934d99 to
b47b622
Compare
tomrford
force-pushed
the
uds/service-variants
branch
from
September 24, 2026 13:15
8ef871c to
0605ba0
Compare
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0605ba0fea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add suppressed ECU reset helpers for physical and functional clients, and CommunicationControl variants 0x04/0x05 with a two-byte node identification number. Request encoding and validation stay shared within uds.
Physical Send, SendECUReset and SendTesterPresent take an explicit waitNRC boolean. false preserves transmission-only behaviour; true holds the existing exchange through P2, accepts initial silence, and reports final negative responses. ResponsePending requires a final response under P2*. Functional broadcasts remain send-only.
ISO-TP reports isotp.ErrFirstFrameTimeout specifically when Exchange.Next's first-frame wait expires. UDS maps only that error to P2/P2*, preserving transport failures such as Flow Control transmit-retry expiry instead of treating them as successful suppressed silence. Caller cancellation and deadlines retain their existing errors, including cancellation observed after a first-frame timeout is classified.
Compatibility: existing physical Send and SendTesterPresent callers must pass the new argument. Callers detecting Exchange.Next's own first-frame timeout must use isotp.ErrFirstFrameTimeout instead of context.DeadlineExceeded.
Existing lifecycle tests cover request bytes, invalid inputs, response validation, suppression, cancellation, incomplete ISO-TP replies, Flow Control retry expiry in both Do and waiting Send, and link reuse after failure. Timed first-frame waits and incomplete segmented replies share the existing exchange-close lifecycle checks. No new dependencies.
Validation: full race tests, vet, formatting and diff checks passed; Windows amd64/arm64/386 compilation passed with CGO disabled. Targeted race tests passed again on final head f42d17b. Independent review found no remaining blocker. No physical ECU validation.