8000 uds: add service variants and suppressed-response waiting by tomrford · Pull Request #85 · tomrford/gocan · GitHub
[go: up one dir, main page]

Skip to content

8000 uds: add service variants and suppressed-response waiting - #85

Merged
tomrford merged 4 commits into
mainfrom
uds/service-variants
Sep 24, 2026
Merged

tomrford merged 4 commits into
mainfrom
uds/service-variants

Conversation

@tomrford
@tomrford tomrford commented Sep 21, 2026 •
Copy link
Copy Markdown
Owner

Add suppressed ECU reset helpers for physical and functional clients, and CommunicationControl variants 0x04/0x05 with a two-byte node identification number. Request encoding and validation stay shared within uds.

Physical Send, SendECUReset and SendTesterPresent take an explicit waitNRC boolean. false preserves transmission-only behaviour; true holds the existing exchange through P2, accepts initial silence, and reports final negative responses. ResponsePending requires a final response under P2*. Functional broadcasts remain send-only.

ISO-TP reports isotp.ErrFirstFrameTimeout specifically when Exchange.Next's first-frame wait expires. UDS maps only that error to P2/P2*, preserving transport failures such as Flow Control transmit-retry expiry instead of treating them as successful suppressed silence. Caller cancellation and deadlines retain their existing errors, including cancellation observed after a first-frame timeout is classified.

Compatibility: existing physical Send and SendTesterPresent callers must pass the new argument. Callers detecting Exchange.Next's own first-frame timeout must use isotp.ErrFirstFrameTimeout instead of context.DeadlineExceeded.

Existing lifecycle tests cover request bytes, invalid inputs, response validation, suppression, cancellation, incomplete ISO-TP replies, Flow Control retry expiry in both Do and waiting Send, and link reuse after failure. Timed first-frame waits and incomplete segmented replies share the existing exchange-close lifecycle checks. No new dependencies.

Validation: full race tests, vet, formatting and diff checks passed; Windows amd64/arm64/386 compilation passed with CGO disabled. Targeted race tests passed again on final head f42d17b. Independent review found no remaining blocker. No physical ECU validation.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 21, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T13:18:36.711461Z 0605ba0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tomrford
tomrford force-pushed the uds/service-variants branch from 7934d99 to b47b622 Compare September 24, 2026 12:50
@tomrford
tomrford force-pushed the uds/service-variants branch from 8ef871c to 0605ba0 Compare September 24, 2026 13:15
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0605ba0fea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread isotp/receive.go Resolved
@tomrford
tomrford merged commit 54dcdda into main Sep 24, 2026
1 check passed
@tomrford
tomrford deleted the uds/service-variants branch September 24, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0