Repository navigation
test: wait for virtual bus capture before ISO-TP retention checks - #56
Merged
Merged
Conversation
TestSendAndReceivePairedLinks compared live capture.End() snapshots while other virtual buses were still recording RX copies, which made main CI flake after #55. Co-authored-by: Tom Ford <t@tomrford.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI failed on
a712dbf(#55) even though that merge only touched CDD parsing. The failing check was:The PR CI for
#55was green. The ISO-TP test is flaky:TestSendAndReceivePairedLinkscompares livecapture.End()snapshots while other virtual buses are still recording RX copies of frames thatSendalready returned. Those late appends moveEnd()and make retention cursors look wrong.This waits until the synctest bubble is idle before taking those snapshots, and splits the queued-retention assertions so a future failure says whether the queued operation or its cancellation moved the cursor.
Testing
mainwithgo test -race(queued cancellation changed send retention, and separatelycompleted transfer retained history)go test -race -count=200 ./isotp -run TestSendAndReceivePairedLinkspassedgo test -race -count=1processes passedgo test -race ./...,go vet ./..., andgofmt -l .passed