8000 test: wait for virtual bus capture before ISO-TP retention checks by tomrford · Pull Request #56 · tomrford/gocan · GitHub
[go: up one dir, main page]

Skip to content

test: wait for virtual bus capture before ISO-TP retention checks - #56

Merged
tomrford merged 1 commit into
mainfrom
cursor/fix-isotp-retention-test-flake-410c
Sep 5, 2026
Merged

tomrford merged 1 commit into
mainfrom
cursor/fix-isotp-retention-test-flake-410c

Conversation

@tomrford
@tomrford tomrford commented Sep 5, 2026 •
Copy link
Copy Markdown
Owner

Main CI failed on a712dbf (#55) even though that merge only touched CDD parsing. The failing check was:

--- FAIL: TestSendAndReceivePairedLinks
    isotp_test.go:369: queued cancellation changed send retention

The PR CI for #55 was green. The ISO-TP test is flaky: TestSendAndReceivePairedLinks compares live capture.End() snapshots while other virtual buses are still recording RX copies of frames that Send already returned. Those late appends move End() and make retention cursors look wrong.

This waits until the synctest bubble is idle before taking those snapshots, and splits the queued-retention assertions so a future failure says whether the queued operation or its cancellation moved the cursor.

Testing

  • Reproduced on main with go test -race (queued cancellation changed send retention, and separately completed transfer retained history)
  • go test -race -count=200 ./isotp -run TestSendAndReceivePairedLinks passed
  • 100 fresh go test -race -count=1 processes passed
  • go test -race ./..., go vet ./..., and gofmt -l . passed
Open in Web Open in Cursor 

TestSendAndReceivePairedLinks compared live capture.End() snapshots while
other virtual buses were still recording RX copies, which made main CI
flake after #55.

Co-authored-by: Tom Ford <t@tomrford.com>
@tomrford
tomrford marked this pull request as ready for review September 5, 2026 15:42
@tomrford
tomrford merged commit b5daff7 into main Sep 5, 2026
2 checks passed
@tomrford
tomrford deleted the cursor/fix-isotp-retention-test-flake-410c branch September 5, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0