Repository navigation
Write ASC header dates in local time - #53
Merged
Merged
Conversation
ASC has no time zone field and Vector tools read the header as local time. Capture timestamps remain UTC instants; only the header label changes. Co-authored-by: Tom Ford <t@tomrford.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASC has no time zone field, and Vector tools read the header clock as local time. The writer previously formatted that date in UTC, which shifted traces against consumer logs that use local timestamps.
This change formats the
dateandBegin Triggerblocklines in the process local zone. Capture timestamps stay UTC instants, and record offsets are unchanged.The existing ASC lifecycle test pins a UTC-4 zone so the header clock is observably local even on UTC hosts.