8000 fix: missing space in version update message by char1es31 · Pull Request #1896 · slskd/slskd · GitHub
[go: up one dir, main page]

Skip to content

fix: missing space in version update message - #1896

Merged
jpdillingham merged 17 commits into
slskd:lintfrom
char1es31:fix/version-string-spacing
Oct 23, 2026
Merged

jpdillingham merged 17 commits into
slskd:lintfrom
char1es31:fix/version-string-spacing

Conversation

@char1es31
@char1es31 char1es31 commented Oct 20, 2026 •
Copy link
Copy Markdown

#1895

Summary

Fixes a small text typo in the update notification modal.

The message previously rendered as:

You are currently running version 0.26.0.0while version 0.26.1 is available.

It now correctly includes the missing space:

You are currently running version 0.26.0.0 while version 0.26.1 is available.

Changes

  • Added the missing space before while in the update banner text in src/web/src/components/App.jsx

AI Usage Disclosure

I used GitHub Copilot to help identify the exact JSX location and confirm the fix. The change is a small UI text correction, and I reviewed and applied the final patch manually.

@char1es31 char1es31 changed the title Fix missing space in version update message fix: missing space in version update message Oct 20, 2026
@jpdillingham
Copy link
Copy Markdown
Member

Thanks for the fix and taking the time to read and apply the guidelines. Both are very much appreciated.

@jpdillingham
jpdillingham changed the base branch from master to lint October 23, 2026 03:49
@jpdillingham
Copy link
Copy Markdown
Member

Just a small linting error; I'll merge this into the lint branch and fix it up.

@jpdillingham
jpdillingham merged commit 39f92b2 into slskd:lint Oct 23, 2026
5 of 6 checks passed
hbjydev pushed a commit to hbjydev/phoebe that referenced this pull request Oct 23, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/slskd/slskd](https://slskd.org) ([source](https://github.com/slskd/slskd)) | patch | `0.26.1` → `0.26.2` |

---

### Release Notes

<details>
<summary>slskd/slskd (ghcr.io/slskd/slskd)</summary>

### [`v0.26.2`](https://github.com/slskd/slskd/releases/tag/0.26.2)

[Compare Source](slskd/slskd@0.26.1...0.26.2)

##### What's Changed

- Suppress .DataProtection-Keys by [@&#8203;jpdillingham](https://github.com/jpdillingham) in [#&#8203;1884](slskd/slskd#1884)
- Disable static asset mapping by [@&#8203;jpdillingham](https://github.com/jpdillingham) in [#&#8203;1885](slskd/slskd#1885)
- Fix bug causing an error when a user requests their place in queue and more than one record for that user+file exists by [@&#8203;jpdillingham](https://github.com/jpdillingham) in [#&#8203;1892](slskd/slskd#1892)
- Create app Mutex as explicitly session-only by [@&#8203;jpdillingham](https://github.com/jpdillingham) in [#&#8203;1893](slskd/slskd#1893)
- Require explicit opt-in for run-time application memory dumps, adjust access level of several core API endpoints by [@&#8203;jpdillingham](https://github.com/jpdillingham) in [#&#8203;1905](slskd/slskd#1905)
- fix: missing space in version update message by [@&#8203;char1es31](https://github.com/char1es31) in [#&#8203;1896](slskd/slskd#1896)
- Fix missing space in version update message by [@&#8203;jpdillingham](https://github.com/jpdillingham) in [#&#8203;1906](slskd/slskd#1906)
- Bump follow-redirects from 1.16.0 to 1.16.1 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1898](slskd/slskd#1898)
- Bump launch-editor from 2.14.1 to 2.14.2 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1904](slskd/slskd#1904)
- Bump source-map-js from 1.0.2 to 1.2.2 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1882](slskd/slskd#1882)
- Bump proxy-addr from 2.0.7 to 2.0.8 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1881](slskd/slskd#1881)
- Bump shell-quote from 1.10.0 to 1.12.0 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1880](slskd/slskd#1880)
- Bump brace-expansion from 1.1.18 to 1.1.21 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1879](slskd/slskd#1879)
- Bump compression from 1.8.1 to 1.8.2 in /src/web by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;1878](slskd/slskd#1878)

##### New Contributors

- [@&#8203;char1es31](https://github.com/char1es31) made their first contribution in [#&#8203;1896](slskd/slskd#1896)

**Full Changelog**: <slskd/slskd@0.26.1...0.26.2>

</details>

---

### Configuration

📅 **Schedule**: (in timezone Europe/London)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNjcuNSIsInVwZGF0ZWRJblZlciI6IjQ0LjE2Ny41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://git.hayden.moe/hayden/phoebe/pulls/963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0