Repository navigation
Import Jobs Containerization - #26
Merged
Merged
Conversation
# Conflicts: # ansible-runner/project
…tainerization # Conflicts: # import-jobs.sh
Resolutions: - modules/coact.py: overage keeps explicit --username/--password-file (graphql_options now means COACT_PASSWORD on this branch) and adopts main's OVERAGE_WINDOW_THRESHOLDS, dropping --windows/--threshold. Completes the truncated comment explaining why. - tests/test_slurm_account_parsing.py: SlurmImporter takes password=. - Makefile, import-jobs.sh: branch versions (main only removed comments). - ansible-runner/project: main's sdf-ansible bump (32f410e). - uv.lock: regenerated with uv lock. Pin setuptools<81: removing cliff dropped setuptools from the lock, and ansible-runner 2.3.1 imports pkg_resources, so every sdf_click.py command failed at import (also affects main). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The deploy overlay, its README and the umbrella CLAUDE.md all point at `make push` and `make update-sdf-ansible`, which this branch had dropped. build now checks out the sdf-ansible submodule first so the image ships the playbooks, and TAG is expanded once so build and push agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
setuptools<81 is pinned in pyproject.toml, so uv sync --frozen already installs it; move the explanation next to the pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uv:latest made builds non-reproducible; pin 0.12.12 by digest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The image COPYs ansible-runner/project, which was empty in CI. Needs the SDF_ANSIBLE_DEPLOY_KEY secret (read-only deploy key on slaclab/sdf-ansible). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The main merge (0e0a47c) staged the stale working-tree checkout (c48e7b1) instead of main's 32f410e. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m.conf slurm.conf sets SlurmUser=slurm, and sacct aborts with "Invalid user for SlurmUser" unless it resolves. SDF hosts create it locally (uid 16924, sdf-ansible install_slurm.yaml) rather than in LDAP. The entrypoint's `sacct -V` check was inside an argument, where set -e does not apply, so a broken config logged an empty version and carried on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2Ryan09
added a commit
that referenced
this pull request
Oct 26, 2026
GitHub only registers workflow_run/workflow_dispatch triggers from the default branch, so the workflow on cli-containerization (sdf-cli#26) has never been runnable. Landing it dispatch-only lets an image be built from that branch with `gh workflow run Docker --ref cli-containerization` before #26 merges. #26 adds the workflow_run trigger together with the Dockerfile. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Keeps this branch's docker_publish.yaml (with the workflow_run trigger) over main's dispatch-only registration copy from #31. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…repos use slaclab requires actions pinned to full commit SHAs; the tag refs failed at "Set up job". Matches coact-api, coactui and user-lookup (checkout v7.0.1, attest-build-provenance v4.1.1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Plain YYYYMMDD-HHMM stamp for every build, plus metadata-action's schedule/branch/tag/pr refs, matching coact-api, coactui and user-lookup instead of a <branch-slug>-<stamp> prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d entrypoint script
2Ryan09
marked this pull request as ready for review
November 3, 2026 17:46
yee379
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.