Repository navigation
test: qualify the #841 nightly candidates (#863) - #876
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD
Thread-local path events (ancestor_alternative_selected, bound_value_avet_range) and Cursor::__memory_peak, compiled only in test and test-hooks builds, for the #863 nightly acceptance tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD
…#863) benches/helpers/shape.rs ports the #841 harness's fixtures, queries and oracles for the six candidates; nightly_candidates.rs times five of them under the existing window/query/recursion routes; the ignored acceptance test pins their answers, paths and charged memory, and the held-cursor churn. Temporary qualify-863.yml and scripts/qualify_863.py measure cost and spread on three runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Six runner runs of qualify-863.yml at ad32658 qualify all six #841 candidates under the amended bar (spread after per-run speed normalization, 3.5-13.1%; max cost 204 s). Evidence, summary script, checksums, bench-coverage-v3 follow-up, counts and pointers. The temporary qualify-863.yml is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD
adityamukho
marked this pull request as ready for review
November 7, 2026 04:14
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #863.
Qualifies the six #841 shape-sweep nightly candidates; all six qualify (evidence; spec
docs/superpowers/specs/2026-11-06-863-nightly-candidates-design.md, plandocs/superpowers/plans/2026-11-06-863-nightly-candidates.md).test-hooks-only path events (ancestor_alternative_selected,bound_value_avet_range) viaminigraf::__path_events, andCursor::__memory_peak. Thedistbinary is unchanged (1,301,592 B at base921b3935and head, local stable).benches/helpers/shape.rs: trimmed port of the Bench: large-scale shape sweeps and recursive optimization isolation #841 fixtures, queries and oracles, checked against the database by a non-ignored test.^window/,^query/,^recursion/, picked up by the existing nightly filters (bench.ymlunchanged).tests/nightly_candidates_acceptance_test.rs: six ignored tests pinning answer, path and charged memory, plus the held-cursor churn (N6, acceptance only).ad326585. The bar was amended twice by decision (see the README): spread is judged after dividing each run by its speed factor, because runners shift ~1.46× on every case at once, also within one CPU model (Benchmark regression: insert (main) #678). Normalized spread is 3.5–13.1%; max cost is 204 s per candidate.Counts (alt bench host, 2026-11-06): default 2,087 passed / 21 ignored;
test-hooks2,125 / 30.Follow-ups after merge (spec §5):
smoke.ymlnightly-candidatesacceptance entry and.github/acceptance/verify.py, as identical PRs to v3 then main.Codex review skipped (quota out until 2026-11-11).
🤖 Generate 8000 d with Claude Code
https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD