Repository navigation
perf: ship full-LTO dist builds and gate their size (#796) - #801
Merged
Merged
Conversation
`profile.dist` no longer overrides release's full LTO with thin LTO, and binary-size.yml builds `--profile dist`, so the gate measures the binary cargo-dist ships. The x86_64 Linux binary is unchanged (it equals the release build); the shipped one shrinks from 1,501,232 to 1,262,584 bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7Qo5yfvBEjzSuUoB2n9
Sizes, clean build times, CLI runtime and cargo-dist packaging on the five release runners and the bench machine; record that the size gate measures the shipped x86_64 Linux dist binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7Qo5yfvBEjzSuUoB2n9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7Qo5yfvBEjzSuUoB2n9
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #796 (v3.0.0).
Change
[profile.dist]no longer setslto = "thin". It inheritsrelease(full LTO,opt-level = "z", one codegen unit,panic = "abort", stripped symbols), so released binaries are built the way the size gate builds.binary-size.ymlbuilds--profile distand measurestarget/dist/minigraf. The gate now checks the x86_64 Linux binary cargo-dist ships, and a later dist-only override would show up in it. The cap stays 1,263,616 bytes.release.ymlis unchanged (it is cargo-dist generated).Measurements
Done on rustc 1.99.1, on the five cargo-dist runners (temporary branch run 41012917889, since deleted) and on the bench machine. Details and every round are in
docs/benchmarks/796-dist-lto.mdanddocs/benchmarks/796-dist-lto/. Measured before #794 merged.--releasebinary the gate already measured (byte-identical locally).dist build --artifacts=localpackages every target. Each packaged binary has the full-LTO size and runs the demo. Windows packages use cargo-dist's+crt-static; a static-CRT build reproduces the packaged size (run 41014187879).Not changed: API, file format, MSRV, size cap, coverage floors. Source-level size work (#797) is still needed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01H2a7Qo5yfvBEjzSuUoB2n9