Repository navigation
test: add replayable storage schedule coverage (#760) - #786
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries must see whole transactions and a stable snapshot while commits and checkpoints run. This adds three bounded schedule tests of the real
FactStorage,SnapshotandPinscode, with test-only synchronization substitutions and an immutable committed-reader fixture. It covers batch visibility, snapshot cutoffs, atomic publication, late appends and pin retention; it does not simulate disk durability or replace real-thread/SIGKILL tests.The focused workflow runs 1,000 schedules per workload on relevant v3 PRs (Linux/macOS/Windows stable plus Linux Rust 1.89). Nightly/manual runs use 10,000 executions per workload for three seeds. Test selection and completed budgets are checked explicitly. Every job preserves logs, failure schedules, Cargo.lock, compiler details and a source archive. The identical workflow-only companion #787 activates the schedule from main after this lands, because GitHub schedules originate from the default branch.
Validation:
docs/testing/deterministic-schedules.mdcontains the boundary audit, alternatives, measured evidence, replay commands and limitations. The deliberate-fault patches and their checker remain manual harness-validation tools. A broader all-test Clippy invocation flagged existing test-code lints, with no diagnostic in the new tests; the normal repository lint gate passed. The complete integration/doc suite was not rerun locally; normal PR CI remains in place.Closes #760. Part of #383.