Repository navigation
test: prove format-v8 scalar key decoders (#693) - #784
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prove the format-v8 scalar key decoders before the v3.0.0 cut, as requested in #693. The earlier issue note deferred this to avoid rework before the v8 key format settled; it did not identify a correctness prerequisite for waiting.
Reader's key bytes, public API, INT-049 messages, and cursor positions unchanged.anyhowmapping under differential, fuzz, and property coverage.-j 4. The matching default-branch workflow change merged in ci: cap scheduled Kani proof concurrency (#693) #783; the version-scoped docs-site companion is docs: describe v3 scalar key decoder proofs (#693) minigraf-docs#83 (draft until this code lands).The approved design and plan are committed in
docs/superpowers/specs/2026-10-29-693-decoder-proofs.mdanddocs/superpowers/plans/2026-10-29-693-decoder-proofs.md. Claude reviewed both before implementation and reviewed the final diff; its follow-up reported no remaining findings.Verification on the bench machine
cargo kani --lib -j 4 --output-format terse -Z unstable-options --harness-timeout 10m: 29/29 passed; slowest final harness 72 s. The measured 29-harness set used 7.6 GiB aggregate CBMC peak RSS at-j 4, under the 16 GiB CI runner budget.cargo test: 1,983 active tests passed; the final patch has 17 ignored tests. Final strengthened key tests also passed separately: 24 passed, both default andtest-hooks.cargo clippy --all-features -- -D warnings,cargo fmt --all --check, and WASI test compilation (cargo test --target wasm32-wasip1 --lib --tests --no-run) passed.cargo build --release: 1,258,936 bytes versus the 1,259,520-byte gate (584-byte margin); baseline was 1,258,712 bytes (+224 bytes).FactStoragewithout v8 key decoding.Refs #693. The issue should close when this v3 PR merges, following the repository's non-default-branch issue policy.