Repository navigation
test(consumer): the browser contract requires the error code (v3) - #13
Merged
Merged
Conversation
@minigraf/browser 2.0.9 rejects with the coded message (minigraf#673), so the contract checks for [PRS-011] instead of the message alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
…#673) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v3 copy of #12, plus a bump of the core pin from
97cd4a2ato the current corev3head,df7282f1. The old pin predates minigraf#675 (BrowserDb error codes on v3). The lockfile dropsgetrandom,libcandr-efi, which core no longer pulls in for this target. Checked locally: the v3 browser package built from this pin passes the consumer test, includingok: the error carries its code ([PRS-011] Unknown command: nosuchcommand).🤖 Generated with Claude Code